<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116463/">https://git.reviewboard.kde.org/r/116463/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5f4e803e6ac9fefd5a45ad93954264b9e6cceba9 by Dennis Nienhüser on behalf of Sanjiban Bairagya to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 28th, 2014, 7:12 a.m. UTC, Sanjiban Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Sanjiban Bairagya.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 7:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331585">331585</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed the id and targetId members of the GeoDataObject class from int to QString. Changed the corresponding getters/setters accordingly.
Adjusted PopupLayer.cpp by changing QString::number(placemark->id()) to a simple placemark->id().
Removed the id member from the following classes: GeoDataTourControl, GeoDataTour, GeoDataWait, GeoDataSoundCue.
Made a few adjustments with TestGeoDataCopy</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataObject.h <span style="color: grey">(ac29c8b)</span></li>
<li>src/lib/marble/geodata/data/GeoDataObject.cpp <span style="color: grey">(736b790)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSoundCue.h <span style="color: grey">(3e2c67d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSoundCue.cpp <span style="color: grey">(9f93c57)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTour.h <span style="color: grey">(1b04904)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTour.cpp <span style="color: grey">(4a8a4ca)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTourControl.h <span style="color: grey">(19c360f)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTourControl.cpp <span style="color: grey">(96c1c9a)</span></li>
<li>src/lib/marble/geodata/data/GeoDataWait.h <span style="color: grey">(abe1480)</span></li>
<li>src/lib/marble/geodata/data/GeoDataWait.cpp <span style="color: grey">(8d71c09)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(bb5eb21)</span></li>
<li>tests/TestGeoDataCopy.cpp <span style="color: grey">(7ae8e48)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116463/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>