<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116463/">https://git.reviewboard.kde.org/r/116463/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 28th, 2014, 6:06 a.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116463/diff/1/?file=250938#file250938line415" style="color: black; font-weight: bold; text-decoration: underline;">tests/TestGeoDataCopy.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void TestGeoDataCopy::copyPlacemark()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">415</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">placemark</span><span class="p">.</span><span class="n">setId</span><span class="p">(</span><span class="mi">281012</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">415</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">placemark</span><span class="p">.</span><span class="n">setId</span><span class="p">(</span><span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">(</span></span><span class="mi">281012</span><span class="p">)<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"281012"</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"281012" is giving error, whereas QString(281012) is not</pre>
<br />
<p>- Sanjiban</p>
<br />
<p>On February 28th, 2014, 7:12 a.m. UTC, Sanjiban Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Sanjiban Bairagya.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 7:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331585">331585</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changed the id and targetId members of the GeoDataObject class from int to QString. Changed the corresponding getters/setters accordingly.
Adjusted PopupLayer.cpp by changing QString::number(placemark->id()) to a simple placemark->id().
Removed the id member from the following classes: GeoDataTourControl, GeoDataTour, GeoDataWait, GeoDataSoundCue.
Made a few adjustments with TestGeoDataCopy</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataObject.h <span style="color: grey">(ac29c8b)</span></li>
<li>src/lib/marble/geodata/data/GeoDataObject.cpp <span style="color: grey">(736b790)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSoundCue.h <span style="color: grey">(3e2c67d)</span></li>
<li>src/lib/marble/geodata/data/GeoDataSoundCue.cpp <span style="color: grey">(9f93c57)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTour.h <span style="color: grey">(1b04904)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTour.cpp <span style="color: grey">(4a8a4ca)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTourControl.h <span style="color: grey">(19c360f)</span></li>
<li>src/lib/marble/geodata/data/GeoDataTourControl.cpp <span style="color: grey">(96c1c9a)</span></li>
<li>src/lib/marble/geodata/data/GeoDataWait.h <span style="color: grey">(abe1480)</span></li>
<li>src/lib/marble/geodata/data/GeoDataWait.cpp <span style="color: grey">(8d71c09)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(bb5eb21)</span></li>
<li>tests/TestGeoDataCopy.cpp <span style="color: grey">(7ae8e48)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116463/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>