<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114901/">https://git.reviewboard.kde.org/r/114901/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 7th, 2014, 7:41 p.m. UTC, <b>Torsten Rahn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all: A warm welcome to Marble development! And thanks a lot for your patch! It's always great to see people getting involved to fix these small details that give Marble the finished look that it deserves.
The usage of StyleSheets with Qt has always been discouraged for "serious" stuff (like Marble ;) ). The StyleSheet parts of the Qt framework have always been shunned as quirky and unreliable. This is partially due to the high-levelness of the concept as well as due the clash with other parts of the Qt framework.
Could you rework your patch to use QPalette to fix the issue? Thanks a lot and keep on rocking! </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It doesn't seem to be possible to change the color of a Button using a palette, since the native styles will overwrite it. I changed the code to generate an icon with the correct color and add it to the pushbutton.</pre>
<br />
<p>- Simon</p>
<br />
<p>On January 7th, 2014, 7:13 p.m. UTC, Simon Danner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Simon Danner.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2014, 7:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The settings display of the positionmarker plugin doesn't show the current selected colors on the buttons, wich i expected. This patch fixes it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/positionmarker/PositionMarker.cpp <span style="color: grey">(45f20c5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114901/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>