<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114719/">https://git.reviewboard.kde.org/r/114719/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On December 29th, 2013, 10:49 a.m. UTC, Mihail Ivchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mihail Ivchenko.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 10:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Factor constellation names out of star plugin.
That's first way to do that.
GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5233734269796352
Second way: https://git.reviewboard.kde.org/r/114720
That's way takes 15-16 ms for parsing csv (first run) and 5 ms with cached file.
I prefer this way, because csv is easier to edit and speed is not very different.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(4bed657)</span></li>
<li>data/stars/names.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(9ac9620)</span></li>
<li>Messages.sh <span style="color: grey">(93fac6b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114719/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>