<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114740/">https://git.reviewboard.kde.org/r/114740/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114740/diff/2/?file=228013#file228013line361" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/GeoDataTreeModel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QVariant GeoDataTreeModel::data( const QModelIndex &index, int role ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">361</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="nf">QVariant</span><span class="p">(</span> <span class="n">QBrush</span><span class="p">(</span> <span class="n">placemark</span><span class="o">-></span><span class="n">style</span><span class="p">()</span><span class="o">-></span><span class="n">listStyle</span><span class="p">().</span><span class="n">backgroundColor</span><span class="p">()</span> <span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The style is a property of the container (parent folder or document), not the placemark. Therefore use this:
+ } else if ( role == Qt::BackgroundRole ) {
+ if ( object->nodeType() == GeoDataTypes::GeoDataPlacemarkType ) {
+ GeoDataPlacemark *placemark = static_cast<GeoDataPlacemark*>( object );
+ if ( placemark->parent() &&
+ ( placemark->parent()->nodeType() == GeoDataTypes::GeoDataFolderType ||
+ placemark->parent()->nodeType() == GeoDataTypes::GeoDataDocumentType ) ) {
+ GeoDataContainer* container = static_cast<GeoDataContainer*>( placemark->parent() );
+ return QVariant( QBrush( container->style()->listStyle().backgroundColor() ));
+ }
+ }
}
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114740/diff/2/?file=228014#file228014line59" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/geodata/handlers/kml/KmlStyleUrlTagHandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GeoNode* KmlstyleUrlTagHandler::parse( GeoParser& parser ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="o">*</span><span class="n">i</span><span class="p">)</span><span class="o">-></span><span class="n">setStyleUrl</span><span class="p">(</span> <span class="n">styleUrl</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You must not change the style of children here, that would overwrite any style they have on their own. When using the parent's style (see comment above), the changes to this file are not needed however.
</pre>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On December 30th, 2013, 5:15 p.m. UTC, Levente Kurusa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Levente Kurusa.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2013, 5:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5832784698408960</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/handlers/kml/KmlStyleUrlTagHandler.cpp <span style="color: grey">(38fee3e)</span></li>
<li>src/lib/marble/GeoDataTreeModel.cpp <span style="color: grey">(36cb5a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114740/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>