<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114722/">https://git.reviewboard.kde.org/r/114722/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114722/diff/2/?file=227858#file227858line1418" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/stars/StarsPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool StarsPlugin::render( GeoPainter *painter, ViewportParams *viewport,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1417</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">path</span><span class="p">.</span><span class="n">arcTo</span><span class="p">(</span><span class="n">fullMoonRect</span><span class="p">,</span> <span class="mi">90</span><span class="p">,</span> <span class="mi">180</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This needs to be
path.arcTo(fullMoonRect, 90, -180);
instead.</pre>
</div>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On December 29th, 2013, 3:05 p.m. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (https://google-melange.appspot.com/gci/task/view/google/gci2013/6453369690390528):
Lunar phases are showing now on the moon pixmap, with opacity 75%
P.S. Screenshots are using the Moon with increased size (in debugging purpose) with yellow pen border.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All possible phase cases (screenshots), unit-tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(4bed657)</span></li>
<li>data/svg/moon.png <span style="color: grey">(1413065)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114722/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/8f264064-e0c8-4daa-ae1c-f2336e352aa7__Screen_Shot_2013-12-29_at_4.53.30_PM.png">Phase 0.0</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/1a1aad38-b586-422e-9cd2-fd739e6b9a07__Screen_Shot_2013-12-29_at_4.55.03_PM.png">Phase 0.25</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/94510852-26e4-45e0-a1e1-4e50602198c0__Screen_Shot_2013-12-29_at_4.55.20_PM.png">Phase 0.5</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/68ed7797-5ebe-48b8-8e13-8382f479d9b6__Screen_Shot_2013-12-29_at_4.55.38_PM.png">Phase 0.75</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/d1eafb0d-eb9f-417a-83e1-b5da10947a60__Screen_Shot_2013-12-29_at_4.55.58_PM.png">Phase 1.0</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>