<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114729/">https://git.reviewboard.kde.org/r/114729/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 29th, 2013, 6:45 p.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114729/diff/2/?file=227893#file227893line125" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/layers/PopupLayer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PopupLayer::setStyle( const GeoDataStyle *style )</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">PopupLayer</span><span class="o">::</span><span class="n">setStyle</span><span class="p">(</span> <span class="k">const</span> <span class="n">GeoDataStyle</span> <span class="o">*</span><span class="n">style</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">PopupLayer</span><span class="o">::</span><span class="n">setStyle</span><span class="p">(</span> <span class="k">const</span> <span class="n">GeoDataStyle</span> <span class="o">*</span><span class="n">style</span> <span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n"><span class="hl">GeoDataPlacemark</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="n"><span class="hl">placemark</span></span><span class="hl"> </span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This method seems to mix up with setContent() now. Why not merge setContent(QString) and setStyle() into setPlacemark(GeoDataPlacemark)?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds good to me.</pre>
<br />
<p>- Torsten</p>
<br />
<p>On December 29th, 2013, 6:46 p.m. UTC, Levente Kurusa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Levente Kurusa.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 6:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a GCI task.
Added handling of $[*] and the displayMode tag.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleWidgetPopupMenu.cpp <span style="color: grey">(d6fb4a6)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature.h <span style="color: grey">(b54e3e5)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature.cpp <span style="color: grey">(ba7d952)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature_p.h <span style="color: grey">(92de8a1)</span></li>
<li>src/lib/marble/layers/PopupLayer.h <span style="color: grey">(06c73c7)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(ff554d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114729/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/ce1c0085-1a82-4839-b476-575a99018c1c__KmlSnippetTagHandler.cpp">Handler for <Snippet></a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/b776a288-8a50-4a2e-917c-990662420e98__KmlSnippetTagHandler.h">Handler for Snippet tag (header)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/b71132cb-f7b5-4c83-804c-82e0256fa00b__snapshot2.png">screenie</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/29/876f1585-3f6b-41a8-81bd-f8f883e00357__baloon.kml">KML used in screenie</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>