<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114353/">http://git.reviewboard.kde.org/r/114353/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 16th, 2013, 8:39 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114353/diff/6/?file=225579#file225579line74" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/TourWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">TourPlayback</span> <span class="o">*</span><span class="n">m_playback</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any technical reason why you didn't turn this into a value, i.e. remove the * in front, like I suggested before? If not, please fix. The advantage of m_playback being a value is that you always know that m_playback exists and that you can wire up its signals in the c'tor of TourWidget already.
Of course, this approach prevents you from passing a GeoDataTour object to its constructor. So you'd have to add e.g. TourPlayback::setTour() and make sure that TourPlayback won't crash if null is passed as tour.
An additional advantage of this approach is that TourPlayback encapsulates all logic for playing a tour. This not only allows us to add new GUIs more easily, but also frees clients of TourPlayback do deal with null-pointer tours themselves.</pre>
</blockquote>
<p>On December 16th, 2013, 8:45 p.m. UTC, <b>Illya Kovalevskyy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now I got it, sorry for dropping your previous issue, I just misunderstood you (it was midnight and so on)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No problem. In order to avoid null-pointer issues inside TourPlayback, you could assign an empty (dummy) GeoDataTour object when you get a null-pointer as input.
Note that TourPlayback should not take ownership of the GeoDataTour object it receives. However, if you create a dummy object, you must delete it at some point. You can solve this by having a static GeoDataTour object which you assign when the user passes a null-pointer.</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On December 16th, 2013, 6:24 p.m. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5813452580847616):
KML tours are played now by TourPlayback class and integrated into TourWidget. It works well and no bugs detected</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Official KML examples, unit-tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/libmarble.qrc <span style="color: grey">(064e1b3)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(d595418)</span></li>
<li>src/lib/marble/TourWidget.ui <span style="color: grey">(874ecfb)</span></li>
<li>src/lib/marble/TourWidget.h <span style="color: grey">(c18c849)</span></li>
<li>src/lib/marble/TourPlayback.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/TourPlayback.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(fd5bd3a)</span></li>
<li>src/apps/marble-ui/icons/16x16/media-record.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-ui/icons/16x16/media-playback-stop.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-ui/icons/16x16/media-playback-start.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-ui/icons/16x16/media-playback-pause.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114353/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>