<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114474/">http://git.reviewboard.kde.org/r/114474/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5802823878967296):
Marble can store routes and bookmarks in an owncloud server. The upload API needs information about the length and duration of routes that are uploaded. The same information should be extracted for routes which are only available on the local system.
* QTime duration(const GeoDataDocument* document) const
* double length(const GeoDataDocument* document) const
* QString name(const GeoDataDocument* document) const
* RouteSyncManager::cachedRouteList() refactored
* OwncloudSyncBackend::uploadRoute() updated
* OwncloudSyncBackend::routeName() removed
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests & manual testing on runtime</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.h <span style="color: grey">(5038f69)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.cpp <span style="color: grey">(889522e)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.cpp <span style="color: grey">(c873ff1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114474/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>