<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114438/">http://git.reviewboard.kde.org/r/114438/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Sanjiban Bairagya.</div>


<p style="color: grey;"><i>Updated Dec. 14, 2013, 11:44 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed the issues that were present in the previous patch</pre>
  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=320009">320009</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Extended the AltitudeMode enum in src/lib/MarbleGlobal.h by the two additional values
- Added a KmlGxAltitudeModeTagHandler that behaves like the existing KmlAltitudeModeTagHandler, but listens to the gx: namespace and parses the two additional values also
- Added a writeAltitudeMode(...) function in KmlGroundOverlayWriter which can both write <altitudeMode> and <gx:altitudeMode> and have it switch between both based on the enum value to write
- Changed KmlCameraTagWriter.cpp, KmlGroundOverlayWriter.cpp, KmlLatLonAltBoxWriter.cpp and KmlModelTagWriter.cpp to use the new writeAltitudeMode(...) function instead of writing altitudeMode manually
- Add a test .kml file to tests/data/ which has various combinations of altitudeMode inside and outside the gx namespace with various values.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/marble/MarbleGlobal.h <span style="color: grey">(b130c0c)</span></li>

 <li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(1918472)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlCameraTagWriter.cpp <span style="color: grey">(a91f2cc)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlGroundOverlayWriter.h <span style="color: grey">(ebcf44e)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlGroundOverlayWriter.cpp <span style="color: grey">(3fa0c0e)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlLatLonAltBoxWriter.cpp <span style="color: grey">(c955c91)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlModelTagWriter.cpp <span style="color: grey">(14186f9)</span></li>

 <li>tests/TestGeoDataWriter.cpp <span style="color: grey">(be2e5f4)</span></li>

 <li>tests/data/AltitudeMode.kml <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114438/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>