<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114270/">http://git.reviewboard.kde.org/r/114270/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit cec39d267b272b7ba8473140f5a79051eeb0cfca by Dennis Nienhüser on behalf of Benjamin Kaiser to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 3rd, 2013, 1:18 p.m. UTC, Benjamin Kaiser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Benjamin Kaiser.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2013, 1:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Give Feedback Whether Owncloud Login Credentials are Correct in Marble.
This has been implemented for both the marble-qt and marble-kde applications settings. Note however that I had to add UI code to both their classes, because the UI building code was not inside the ControlView class. The logic behind the login credential checking was implemented in the correct place (OwncloudSyncBackend).
GCI task: http://www.google-melange.com/gci/task/view/google/gci2013/5900404730626048</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run both the `marble` (marble-kde) and `marble-qt` applications. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-kde/marble_part.h <span style="color: grey">(ddb91ea)</span></li>
<li>src/apps/marble-kde/marble_part.cpp <span style="color: grey">(082ad5e)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(a713272)</span></li>
<li>src/lib/marble/MarbleCloudSyncSettingsWidget.ui <span style="color: grey">(9257dac)</span></li>
<li>src/lib/marble/QtMarbleConfigDialog.h <span style="color: grey">(95be36d)</span></li>
<li>src/lib/marble/QtMarbleConfigDialog.cpp <span style="color: grey">(b8a85c0)</span></li>
<li>src/lib/marble/cloudsync/CloudSyncManager.h <span style="color: grey">(7955bc8)</span></li>
<li>src/lib/marble/cloudsync/CloudSyncManager.cpp <span style="color: grey">(caa9536)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.h <span style="color: grey">(715f60c)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.cpp <span style="color: grey">(8af8182)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114270/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>