<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114339/">http://git.reviewboard.kde.org/r/114339/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit a54e032a57669a4bb59b763abe0b2f0ea61786ce by Illya Kovalevskyy to branch master.</pre>
 <br />









<p>- Commit Hook</p>


<br />
<p>On December 7th, 2013, 12:02 a.m. UTC, Illya Kovalevskyy wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Illya Kovalevskyy.</div>


<p style="color: grey;"><i>Updated Dec. 7, 2013, 12:02 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5841112170233856):

Handlers/writers for gx:SoundCue (and all related new tags) are created, related tests are adjusted. Reading/writing for the gx:Playlist tag (which one is main container of gx:SoundCue is working well).</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Related unit tests</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(9206b3f)</span></li>

 <li>src/lib/marble/geodata/data/GeoDataPlaylist.h <span style="color: grey">(8b0e411)</span></li>

 <li>src/lib/marble/geodata/data/GeoDataPlaylist.cpp <span style="color: grey">(dc85421)</span></li>

 <li>src/lib/marble/geodata/data/GeoDataSoundCue.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/data/GeoDataSoundCue.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/data/GeoDataTour.h <span style="color: grey">(9415c60)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h <span style="color: grey">(2a45419)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp <span style="color: grey">(6473bca)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlHrefTagHandler.cpp <span style="color: grey">(6f9204a)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlSoundCueTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmlSoundCueTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmldelayedStartTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/handlers/kml/KmldelayedStartTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/geodata/parser/GeoDataTypes.h <span style="color: grey">(b201936)</span></li>

 <li>src/lib/marble/geodata/parser/GeoDataTypes.cpp <span style="color: grey">(87b1f00)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.h <span style="color: grey">(24e87f9)</span></li>

 <li>src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp <span style="color: grey">(896650f)</span></li>

 <li>tests/TestGeoDataWriter.cpp <span style="color: grey">(4d79ce0)</span></li>

 <li>tests/data/Tour.kml <span style="color: grey">(3b04c83)</span></li>

 <li>tests/data/TourWait.kml <span style="color: grey">(52c724e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114339/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>