<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114170/">http://git.reviewboard.kde.org/r/114170/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On December 2nd, 2013, 11:39 p.m. EET, <b>Dennis Nienhüser</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/114170/diff/10/?file=222201#file222201line33" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/MovieCapture.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 10)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">QTimer</span> <span class="n">frameTimer</span><span class="p">;</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">m_ prefix also for private class members</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should we really use this for pimpl members?</pre>
<br />




<p>- Illya</p>


<br />
<p>On December 2nd, 2013, 11:22 p.m. EET, Illya Kovalevskyy wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Illya Kovalevskyy.</div>


<p style="color: grey;"><i>Updated Dec. 2, 2013, 11:22 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5805119807422464):

Implementation of timer-based fps marblewidget caster. Current impl saves video file, compiled from bmp files saved in temporary directory with avconv/ffmpeg (avconv is a prior one).</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">UI/UX, unit-tests</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/apps/marble-qt/QtMainWindow.h <span style="color: grey">(80ae250)</span></li>

 <li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(a713272)</span></li>

 <li>src/apps/marble-ui/icons/16x16/tool-animator.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/apps/marble-ui/marble.qrc <span style="color: grey">(5ff3a32)</span></li>

 <li>src/lib/marble/CMakeLists.txt <span style="color: grey">(8f2c6eb)</span></li>

 <li>src/lib/marble/MovieCapture.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/MovieCapture.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/MovieCaptureDialog.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/MovieCaptureDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/marble/MovieCaptureDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tool-animator.png <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114170/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/12/01/e63d9e9f-71e8-449d-99ee-9a2b422061a4__video.png">WEBM video running</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/12/02/c31ec1f1-e78a-4e40-bd95-425ac029724a__formats.png">Recording dialog</a></li>

</ul>





  </td>
 </tr>
</table>








  </div>
 </body>
</html>