<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114199/">http://git.reviewboard.kde.org/r/114199/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114199/diff/1/?file=221295#file221295line153" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/cloudsync/CloudRouteModel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QIcon CloudRouteModel::preview( const QModelIndex &index ) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">153</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">connect</span><span class="p">(</span> <span class="n">reply</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">errorString</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">previewNetworkError</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">))</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no such signal QNetworkReply::errorString(QString).</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114199/diff/1/?file=221299#file221299line166" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/cloudsync/OwncloudSyncBackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void OwncloudSyncBackend::uploadRoute( const QString ×tamp )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">166</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_routeUploadReply</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">errorString</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">routeNetworkError</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">))</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no such signal QNetworkReply::errorString(QString).</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114199/diff/1/?file=221299#file221299line175" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/cloudsync/OwncloudSyncBackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void OwncloudSyncBackend::uploadRoute( const QString ×tamp )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">175</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_routeListReply</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">errorString</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">routeNeworkError</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">))</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no such signal QNetworkReply::errorString(QString).</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114199/diff/1/?file=221299#file221299line184" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/cloudsync/OwncloudSyncBackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void OwncloudSyncBackend::uploadRoute( const QString ×tamp )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">184</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_routeDownloadReply</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">errorString</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">routeNetworkError</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">))</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no such signal QNetworkReply::errorString(QString).</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114199/diff/1/?file=221299#file221299line193" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/cloudsync/OwncloudSyncBackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void OwncloudSyncBackend::uploadRoute( const QString ×tamp )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">193</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_routeDeleteReply</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">errorString</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">routeNetworkError</span><span class="p">(</span><span class="n">QString</span><span class="o">&</span><span class="p">))</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no such signal QNetworkReply::errorString(QString).</pre>
</div>
<br />
<p>- Utku Aydın</p>
<br />
<p>On November 29th, 2013, 12:17 p.m. UTC, Utku Aydın wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Utku Aydın.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 12:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Posted here on behalf of GCI student Eric Newberry. Task: https://www.google-melange.com/gci/task/view/google/gci2013/5773791242223616
The patch adds ability to Marble's desktop version to notify the user if anything goes wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-kde/marble_part.h <span style="color: grey">(ddb91ea3e44077ec84afa597c8136a4cc51f3b2a)</span></li>
<li>src/apps/marble-kde/marble_part.cpp <span style="color: grey">(082ad5ece6ec7de3e0441ed8384b46be8d66ba49)</span></li>
<li>src/apps/marble-qt/QtMainWindow.h <span style="color: grey">(80ae2505d97ecfbb07c6db7ffdb0cd0c369b3eb6)</span></li>
<li>src/apps/marble-qt/QtMainWindow.cpp <span style="color: grey">(a7132726e74bb22984b1fd1bd2ebbf3c5d4206d6)</span></li>
<li>src/lib/marble/cloudsync/CloudRouteModel.h <span style="color: grey">(d5d1c1ff7dc4a7b52e424dbb212e7792387afc85)</span></li>
<li>src/lib/marble/cloudsync/CloudRouteModel.cpp <span style="color: grey">(e1ad467f4cea5052ef4f24d2bed82eb9c923d9a2)</span></li>
<li>src/lib/marble/cloudsync/CloudSyncManager.h <span style="color: grey">(7955bc8a21b51d8c77b001c5d5b809a6c18ad721)</span></li>
<li>src/lib/marble/cloudsync/CloudSyncManager.cpp <span style="color: grey">(caa953640f3c14315bf250cf6ae051a4f205b2ec)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.h <span style="color: grey">(715f60cfaa9500b16c88444d6d4ecb5bda958ccd)</span></li>
<li>src/lib/marble/cloudsync/OwncloudSyncBackend.cpp <span style="color: grey">(8af8182a676d08f7af3f9319a57b0f131de14607)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.h <span style="color: grey">(c7a9f6826e8f8f4abc0869d09aed79d71e06c0fb)</span></li>
<li>src/lib/marble/cloudsync/RouteSyncManager.cpp <span style="color: grey">(c873ff176cd83a97f172e76b058afd8957100d32)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114199/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>