<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114082/">http://git.reviewboard.kde.org/r/114082/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did those, however this diff file is merged with this review request: https://git.reviewboard.kde.org/r/114144/ . since it uses comboBoxes as well. so please review that also.</pre>
<br />
<p>- Yazeed</p>
<br />
<p>On November 25th, 2013, 2:38 p.m. UTC, Yazeed Zoabi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Yazeed Zoabi.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2013, 2:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can now use add comboboxes in maps.
In order to use this feature, new attributes to sections are introduced: combobox, comboboxOrder.
the comboboxOrder attribute should appear twice, once to indicate that top of a combobox, and the other to indicate it's bottom :D. (top: "first", middle: [anything but first or last], bottom: "last")
note: You must keep checkable="true" (one reason for that is for options to function as checkboxes in older versions of marble)
Example:
<section name="first" checkable="true" combobox="true" comboboxOrder="first" connect="first" spacing="12">
<heading>First option</heading>
</section>
<section name="middle" checkable="true" combobox="true" comboboxOrder="" connect="middle" spacing="12">
<heading>Middle option</heading>
</section>
<section name="last" checkable="true" combobox="true" comboboxOrder="last" connect="last" spacing="12">
<heading>Last option</heading>
</section>
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kubuntu 13.10 . Qt version: 4.8.4 .</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(e7fb4b5)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(644dd0f)</span></li>
<li>src/lib/marble/geodata/handlers/DgmlOptionTagHandler.h <span style="color: grey">(e69de29)</span></li>
<li>src/lib/marble/geodata/handlers/DgmlOptionTagHandler.cpp <span style="color: grey">(e69de29)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h <span style="color: grey">(d426e0d)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp <span style="color: grey">(20b0ebe)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp <span style="color: grey">(66ee562)</span></li>
<li>src/lib/marble/geodata/parser/GeoSceneTypes.h <span style="color: grey">(5fd1cdb)</span></li>
<li>src/lib/marble/geodata/parser/GeoSceneTypes.cpp <span style="color: grey">(a653d02)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneOption.h <span style="color: grey">(e69de29)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneOption.cpp <span style="color: grey">(e69de29)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.h <span style="color: grey">(5224f43)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.cpp <span style="color: grey">(9d7bf77)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114082/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/2930e2e7-a1e9-46f5-b84e-ba69ec7aa184__snapshot4.png">snapshot4.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/804f61ea-5802-4c44-b099-cb830771c8e9__snapshot5.png">snapshot5.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/d7e5fe3e-7fe6-4aaa-8341-fd4b0fe63a41__snapshot6.png">snapshot6.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>