<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114031/">http://git.reviewboard.kde.org/r/114031/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e93233d9812b2509eac82959c9527ba36b15b4e4 by Dennis Nienhüser on behalf of Yazeed Zoabi to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 22nd, 2013, 3:38 p.m. UTC, Yazeed Zoabi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.</div>
<div>By Yazeed Zoabi.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2013, 3:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What has basically changed, is that Radio buttons are now implemented in the Marble Legend browser.. you can now add sections (in dgml files) with an Multiple radio buttons (a group of radio buttons) must have the same value for the radio attribute to indicate the group. (a special value for each group) .
Example of sections that are now shown as radio buttons :
<section name="riciolli" radio="RH" checkable="true" connect="riciolli" spacing="12">
<heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Giambattista_Riccioli">Riciolli</a>]]></heading>
</section>
<section name="hevelius" radio="RH" checkable="true" connect="hevelius" spacing="12">
<heading><![CDATA[<a href="http://en.wikipedia.org/wiki/Johannes_Hevelius">Hevelius</a>]]></heading>
</section>
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing was done on Kubuntu 13.10 .
tested the same dgml file with an older marble version (with no radio button implementation), and works fine with checkboxes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(c2a8c62)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(53524a4)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h <span style="color: grey">(2785289)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp <span style="color: grey">(6940d62)</span></li>
<li>src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp <span style="color: grey">(82aadc9)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.h <span style="color: grey">(7e60c3c)</span></li>
<li>src/lib/marble/geodata/scene/GeoSceneSection.cpp <span style="color: grey">(8268530)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114031/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>