<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113998/">http://git.reviewboard.kde.org/r/113998/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 97d3e3346069c70b59ffc3c183e8bb20d391e295 by Dennis Nienhüser on behalf of Mohammed Nafees to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 21st, 2013, 8:35 p.m. UTC, Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2013, 8:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This new runner plugin uses GPSBabel as backend, parses NMEA files in Marble. It uses GPSBabel to convert NMEA files to KML files temporarily and renders the GeoDataDocument in Marble. If the user doesn't have gpsbabel installed on his system, the option for opening NMEA files in the Open File dialog don't appear.
http://www.google-melange.com/gci/task/view/google/gci2013/5820716041633792</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, testing done on Ubuntu 13.04 64-bit </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/CMakeLists.txt <span style="color: grey">(97e0b2d)</span></li>
<li>src/plugins/runner/gpsbabel/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpsbabel/GpsbabelPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpsbabel/GpsbabelPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpsbabel/GpsbabelRunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpsbabel/GpsbabelRunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113998/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>