<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114051/">http://git.reviewboard.kde.org/r/114051/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. cmake caching the result of globbing .po files might play bad tricks, so a little bit help wouldn't hurt, .e.g. by adding
COMMENT "Generating translations from .po files found in data/lang. Make sure to re-run cmake if you do changes to .po files."
in the ADD_CUSTOM_TARGET(translations ...) call or via
test -e CMakeLists.txt && touch CMakeLists.txt
at the end of download-translations.bash
</pre>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On November 23rd, 2013, 10:57 a.m. UTC, Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2013, 10:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If translation files in .po format are present in ${src}/data/lang, .qm files will be generated automatically in the build directory, ready for installation during "make install". The .po files can be downloaded by running the script "download-translations.bash" which also resides in ${src}/data/lang.
The motivation for this change is to simplify packaging for the Maemo5 version where the build system had to be patched for installation of translations.
Note that I'd like to backport this patch to Marble 1.7 (KDE 4.12). Any objections?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested only with Qt 4. Any volunteers for Qt 5?
All .po files were converted such that the Qt version of Marble recognized the translations under Arch Linux and Maemo5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/CMakeLists.txt <span style="color: grey">(22f55772a8dcf46bc91ad66f921f1ccf4b03033f)</span></li>
<li>data/lang/.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/lang/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/lang/download-translations.bash <span style="color: grey">(PRE-CREATION)</span></li>
<li>tools/CMakeLists.txt <span style="color: grey">(f3bd4b709c6828634411e63adeca4bbcdf57019d)</span></li>
<li>tools/translations/CMakeLists.txt <span style="color: grey">(3d1f6af7b8a04ef3f214df9fe3e5298bd5cf24cd)</span></li>
<li>tools/translations/marble_i18n.sh <span style="color: grey">()</span></li>
<li>tools/translations/marble_qt_i18n.bash <span style="color: grey">(5395703d79773765efaeece9f0422639f2952317)</span></li>
<li>tools/translations/merge_ts_po.cpp <span style="color: grey">()</span></li>
<li>tools/translations/routing-instructions_i18n.bash <span style="color: grey">()</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114051/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>