<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112908/">http://git.reviewboard.kde.org/r/112908/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9c0c8cb701efdee019e64a1285ed4182b1ab4bb9 by Bernhard Beschow to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 23rd, 2013, 6:27 p.m. UTC, Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 6:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The philosophy behind QML is to allow writing new components in few lines of code.
In addition, I'd like to see 3rd parties to come up with their own UI ideas.
Therefore, let's make the components non-reusable by merging them into Marble Touch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/CMakeLists.txt <span style="color: grey">(22ec982d43e360eacccebbcce87e0e4b5a408bb6)</span></li>
<li>src/plugins/qt-components/CMakeLists.txt <span style="color: grey">(e2db1bfa6c5a085f16526e3150b5e3bef2a2f389)</span></li>
<li>src/plugins/qt-components/FileDialog.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/FileOpenDialog.qml <span style="color: grey">(3e2143ef330d2319f3546cb4e98a6e29802c052a)</span></li>
<li>src/plugins/qt-components/FileSaveDialog.qml <span style="color: grey">(884273b2e4fa6fcccf0fe3d2d050f43f67d24d34)</span></li>
<li>src/plugins/qt-components/PlacemarkEditor.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/QtComponentsPlugin.h <span style="color: grey">(f1f95f007bb416200327bd5c7a429f9e95527fde)</span></li>
<li>src/plugins/qt-components/QtComponentsPlugin.cpp <span style="color: grey">(1b3f9c9921c9160623b9e1c525864a6b37be7d4f)</span></li>
<li>src/plugins/qt-components/RouteEditor.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/SearchField.qml <span style="color: grey">(e52077ad79960702d928861ce76176a9e7e91e7f)</span></li>
<li>src/plugins/qt-components/ViaPointEditor.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/harmattan/MarbleMenuLayout.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/harmattan/MarbleToolIcon.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/harmattan/MenuItemSwitch.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/marker-direction.svg <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/marker-yellow.svg <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/marker.svg <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/placemark.svg <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/plasma/MarbleMenuLayout.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/plasma/MarbleToolIcon.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/plasma/MenuItemSwitch.qml <span style="color: grey">()</span></li>
<li>src/plugins/qt-components/qmldir <span style="color: grey">(40cab8f4bd73256d944b900175247c67f8e511a2)</span></li>
<li>src/plugins/qt-components/qtcomponents.qrc <span style="color: grey">(eca7c20c812e9c65843e54090fe93f8233ad423c)</span></li>
<li>src/qt-components/marble-touch/AboutMarblePage.qml <span style="color: grey">(72f42e4cb49ee460264b3b8e9be0a82f0bba553c)</span></li>
<li>src/qt-components/marble-touch/CMakeLists.txt <span style="color: grey">(374b1c6c18fb0eb4c5aebd1e175fca6b3837cbf4)</span></li>
<li>src/qt-components/marble-touch/CloudSyncPage.qml <span style="color: grey">(d019695ce7c70066ef4c8c881a74c834e4131e0b)</span></li>
<li>src/qt-components/marble-touch/MainWidget.qml <span style="color: grey">(844dc0b9fc338174a0a4ad2101b9f53e07bb8ca1)</span></li>
<li>src/qt-components/marble-touch/MapThemePage.qml <span style="color: grey">(ae8b078b220588af483d482525d0e980911fe9f3)</span></li>
<li>src/qt-components/marble-touch/MapThemeSelectionPage.qml <span style="color: grey">(55e2da5f90fc4fba45353a25f40c23af1935881c)</span></li>
<li>src/qt-components/marble-touch/OfflineDataPage.qml <span style="color: grey">(2c04038b59f5c62ef58877a44dfe74a99d1f2a67)</span></li>
<li>src/qt-components/marble-touch/PositionIndicator.qml <span style="color: grey">(2f210117715f7f646d0879710885a34dd1f7db5c)</span></li>
<li>src/qt-components/marble-touch/PreferencesPage.qml <span style="color: grey">(b838d7edf91875d524c54d2994b36a1daa86cd87)</span></li>
<li>src/qt-components/marble-touch/activities/Explore.qml <span style="color: grey">(604ca6609d4e51ace296b4e3aec3f958ac4312c1)</span></li>
<li>src/qt-components/marble-touch/activities/Friends.qml <span style="color: grey">(0b08478d6bdb7924b2b45dc269c4fc194a5afce5)</span></li>
<li>src/qt-components/marble-touch/activities/Geocaching.qml <span style="color: grey">(48c14fa0abe6bcb6e466cf298e913b7fbaf394fa)</span></li>
<li>src/qt-components/marble-touch/activities/Navigation.qml <span style="color: grey">(47bd3694d6ce17aa8aa58b5482530838d7bc7f5f)</span></li>
<li>src/qt-components/marble-touch/activities/Placemark.qml <span style="color: grey">(e1316d2085f0e68e8a08b0ead0da7204ba5f2782)</span></li>
<li>src/qt-components/marble-touch/activities/Routing.qml <span style="color: grey">(73e325f581b298fbd2a36cf1ef5bc546db823181)</span></li>
<li>src/qt-components/marble-touch/activities/Search.qml <span style="color: grey">(31e150905b59673b75b08d87ff2c7f8483ae88bb)</span></li>
<li>src/qt-components/marble-touch/activities/SpaceView.qml <span style="color: grey">(aee54823c32c51c5fbc7a9c02f7005e99b84c1e1)</span></li>
<li>src/qt-components/marble-touch/activities/Tracking.qml <span style="color: grey">(5954f05386863b1beb50266399fb8d3cfb3263d4)</span></li>
<li>src/qt-components/marble-touch/activities/VirtualGlobe.qml <span style="color: grey">(7eb6cd1d91695b85f21345d0f0cc2e3bb2576561)</span></li>
<li>src/qt-components/marble-touch/activities/Weather.qml <span style="color: grey">(623a685b7e9e1805b2e6bcca8ad2e206819dbf7c)</span></li>
<li>src/qt-components/marble-touch/harmattan/MarbleWindow.qml <span style="color: grey">(ec55b8fc8a256ccf7bc712dff4e9a54acc56b7cd)</span></li>
<li>src/qt-components/marble-touch/harmattan/harmattan.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/qt-components/marble-touch/meego.qrc <span style="color: grey">(a9e3bf70762fa3323feabbea73d3226eaebaa154)</span></li>
<li>src/qt-components/marble-touch/plasma/MarbleWindow.qml <span style="color: grey">(aaca0be1698a40f876c1b34edbcc51a4294fd1e0)</span></li>
<li>src/qt-components/marble-touch/plasma/plasma.qrc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112908/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>