<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111810/">http://git.reviewboard.kde.org/r/111810/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 1st, 2013, 3:13 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all, I tested your patch by adopting the vectorosm map theme. It works very well! Here are my comments on your code:</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You mean you used the VectorOSM Map theme as it was?
Because I changed this parser because the old one was just to match the tile format that was written in the vectorosm.dgml file which is not exact GeoJSON. With this new parser those tiles ( from osmonimski.ru ) should not work but all the tiles that really follow the GeoJSON format should. So I don't know if you changed the URL in the dgml file where to get the tiles from to try the parser.
My idea now was to make it work with other vector tile servers because I haven't been able to make the vectorosm map theme work. Maybe there have been some changes in the code that need the vector tile managing system to be updeated. But if you say that it has worked with you there might be something I'm doing wrong. I will start with it as soon as the parser is aproved =)</pre>
<br />
<p>- Ander</p>
<br />
<p>On August 1st, 2013, 4:53 p.m. UTC, Ander Pijoan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Ander Pijoan.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2013, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-Changed Marble's GeoJSON parser (which was a test for just matching Kothic's GeoJSON like format) to match the exact GeoJSON standard :
http://www.geojson.org/geojson-spec.html#id3
-Supported geometry types :
Point
MultiPoint
LineString
MultiLineString
Polygon
MultiPolygon
-Not supported geometry types:
GeometryCollection
-Geometry properties are compared with GeoDataFeature's OsmVisualCategory to see if any of the properties matches a style to give to the geometry. If not it will be shown as a black line.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some test files :
http://tile.openstreetmap.us/vectiles-skeletron/12/1206/1539.json (this file will matches road styles)
http://tile.openstreetmap.us/vectiles-buildings/12/1206/1539.json (this file matches some other geometry types)
http://tile.openstreetmap.us/vectiles-water-areas/12/1206/1539.json (this file matches some other multi geometry types)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/json/JsonParser.h <span style="color: grey">(4fb072c)</span></li>
<li>src/plugins/runner/json/JsonParser.cpp <span style="color: grey">(86cf66b)</span></li>
<li>src/plugins/runner/json/JsonPlugin.cpp <span style="color: grey">(e7ff770)</span></li>
<li>src/plugins/runner/json/JsonRunner.cpp <span style="color: grey">(2098e1f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111810/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>