<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111769/">http://git.reviewboard.kde.org/r/111769/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Michael Zanetti.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2013, 2:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This updated patch uses qt4_automoc for cmake versions < 2.8 and cmake's automoc for newer versions.
This should keep compatibility to Maemo (or other platforms where only older cmake versions are available) while opening up the way for the Qt5 port.
Downside of this is, that currently we need to use both macros:
marble_qt4_automoc( ${SRCS} )
and
marble_cmake_automoc( ${TARGET} )
Depending on the cmake version, only one of the macros actually does something.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit switches from qt4_automoc to cmake automoc.
This is one more step on the way to make Marble work with Qt5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on Ubuntu with Qt4 and -DQTONLY=1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>MarbleMacros.cmake <span style="color: grey">(5a0aedc)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b2a3e09)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(16c7fab)</span></li>
<li>src/plugins/declarative/CMakeLists.txt <span style="color: grey">(300ebed)</span></li>
<li>src/plugins/positionprovider/geoclue/GeoCute/CMakeLists.txt <span style="color: grey">(abde4f2)</span></li>
<li>src/plugins/render/aprs/CMakeLists.txt <span style="color: grey">(4896a8e)</span></li>
<li>src/plugins/render/earthquake/CMakeLists.txt <span style="color: grey">(6a4704e)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/CMakeLists.txt <span style="color: grey">(872e5e1)</span></li>
<li>src/plugins/render/elevationprofilemarker/CMakeLists.txt <span style="color: grey">(bbe043e)</span></li>
<li>src/plugins/render/fileview/CMakeLists.txt <span style="color: grey">(adfa961)</span></li>
<li>src/plugins/render/foursquare/CMakeLists.txt <span style="color: grey">(0b62efd)</span></li>
<li>src/plugins/render/license/CMakeLists.txt <span style="color: grey">(90c0097)</span></li>
<li>src/plugins/render/navigation/CMakeLists.txt <span style="color: grey">(b0597aa)</span></li>
<li>src/plugins/render/opendesktop/CMakeLists.txt <span style="color: grey">(50da329)</span></li>
<li>src/qt-components/marble-touch/CMakeLists.txt <span style="color: grey">(52940a6)</span></li>
<li>src/routing-instructions/CMakeLists.txt <span style="color: grey">(c1e6386)</span></li>
<li>src/tilecreator/CMakeLists.txt <span style="color: grey">(f1eed44)</span></li>
<li>tools/tilecreator-srtm2/CMakeLists.txt <span style="color: grey">(8088187)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111769/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>