<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110735/">http://git.reviewboard.kde.org/r/110735/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e2a5ba77195ee3067724cc8c660a550ae41c270e by Dennis Nienhüser on behalf of Thomas Jarosch to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 30th, 2013, 5:17 p.m. UTC, Thomas Jarosch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thomas Jarosch.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 5:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi,
when you load a route with less via points than currently active vias,
the intention of the code was to remove all unneeded via points.
The logic to do this was broken: Every time you remove an element,
m_RouteRequest.size() will also decrement -> one element was always left over.
Attached patch fixes this.
*** Steps to reproduce ***
Create a normal route with two vias and save it.
Clear the route, create a new one and add some random vias.
If you now load the route with the two via points,
one previous via point is left over.
Thomas
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on desktop Qt version.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/routing/RoutingManager.cpp <span style="color: grey">(c0554cf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110735/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>