<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110677/">http://git.reviewboard.kde.org/r/110677/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e88bf2bd8abfb243eecac7c8e423c304d30b54f6 by Dennis Nienhüser on behalf of Thomas Jarosch to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 28th, 2013, 8:15 p.m. UTC, Thomas Jarosch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Dennis Nienhüser.</div>
<div>By Thomas Jarosch.</div>
<p style="color: grey;"><i>Updated May 28, 2013, 8:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We were checking the uninitialized member "m_dimension"
in setDimenson() if it already contained the same value.
Remove this optimization as it's not really needed.
valgrind complained:
==27427== Conditional jump or move depends on uninitialised value(s)
==27427== at 0x72A9141: Marble::LatLonEdit::setDimension(Marble::Dimension) (LatLonEdit.cpp:520)
==27427== by 0x72A95B8: Marble::LatLonEdit::LatLonEdit(QWidget*, Marble::Dimension, Marble::GeoDataCoordina
==27427== by 0x72FC7F6: Ui_UiEditBookmarkDialog::setupUi(QDialog*) (ui_EditBookmarkDialog.h:83)
==27427== by 0x72FC22A: Marble::EditBookmarkDialogPrivate::initialize() (EditBookmarkDialog.cpp:68)
==27427== by 0x72FC3C9: Marble::EditBookmarkDialog::EditBookmarkDialog(Marble::BookmarkManager*, QWidget*)
==27427== by 0x4254E0: Marble::MainWindow::openEditBookmarkDialog() (QtMainWindow.cpp:551)
==27427== by 0x4FBDC8E: QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (in /usr/lib64/lib
==27427== by 0x57463F1: QAction::triggered(bool) (in /usr/lib64/libQtGui.so.4.8.4)
==27427== by 0x57465DF: QAction::activate(QAction::ActionEvent) (in /usr/lib64/libQtGui.so.4.8.4)
==27427== by 0x5B7FD92: ??? (in /usr/lib64/libQtGui.so.4.8.4)
==27427== by 0x5B86178: ??? (in /usr/lib64/libQtGui.so.4.8.4)
==27427== by 0x579BF28: QWidget::event(QEvent*) (in /usr/lib64/libQtGui.so.4.8.4)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/LatLonEdit.cpp <span style="color: grey">(bdbc366)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110677/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>