<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110509/">http://git.reviewboard.kde.org/r/110509/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 542b43cedfb9b74ccb3b7a5f2691c72d16ef1a46 by Dennis Nienhüser on behalf of Sanjiban Bairagya to branch master.</pre>
 <br />









<p>- Commit</p>


<br />
<p>On May 18th, 2013, 3:46 p.m. UTC, Sanjiban Bairagya wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Sanjiban Bairagya.</div>


<p style="color: grey;"><i>Updated May 18, 2013, 3:46 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Previously there was no way to write the <Model> tag in the kml files, if required. I added the necessary KmlModelTagWriter which makes it possible now, along with a test for checking it</pre>
  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=318288">318288</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/geodata/CMakeLists.txt <span style="color: grey">(b82b33c)</span></li>

 <li>src/lib/geodata/parser/GeoDocument.cpp <span style="color: grey">(ee6834a)</span></li>

 <li>src/lib/geodata/writers/kml/KmlGroundOverlayWriter.cpp <span style="color: grey">(30692a5)</span></li>

 <li>src/lib/geodata/writers/kml/KmlLinkTagWriter.h <span style="color: grey">(0da7d16)</span></li>

 <li>src/lib/geodata/writers/kml/KmlLinkTagWriter.cpp <span style="color: grey">(e3e7070)</span></li>

 <li>src/lib/geodata/writers/kml/KmlLookAtTagWriter.cpp <span style="color: grey">(c7acd01)</span></li>

 <li>src/lib/geodata/writers/kml/KmlModelTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/lib/geodata/writers/kml/KmlModelTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/TestGeoDataWriter.cpp <span style="color: grey">(6487804)</span></li>

 <li>tests/data/MackyModel.kml <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110509/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>