<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110058/">http://git.reviewboard.kde.org/r/110058/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 28th, 2013, 2:50 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110058/diff/5/?file=139648#file139648line41" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/RenderPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class RenderPlugin::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_stationary</span><span class="p">(</span> <span class="nb">true</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this attribute (and any code depending on it) can be avoided by fixing AbstractFloatItem in just one place. Try to surround paintEvent(...) in AbstractFloatItem::render() with:
painter->save();
painter->translate( -viewport->pan() );
paintEvent(...);
painter->restore();</pre>
</blockquote>
<p>On April 29th, 2013, 6:27 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In fact it seems to me that you could remove all QPainter::translate() calls and all code related to LayerInterface/RenderPlugin::stationary() if you adapted all methods in SphericalProjection. Perhaps it's even sufficient to only adapt the projection classes to get everything rendered correctly.
One issue I currently see, however, is that the crosshairs don't indicate the center of the map. This results in the map shifting if pan != 0 and the map is zoomed in or out.</pre>
</blockquote>
<p>On May 13th, 2013, 9:13 p.m. UTC, <b>Paul Nader</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"In fact it seems to me that you could remove all QPainter::translate() calls and all code related to LayerInterface/RenderPlugin::stationary() if you adapted all methods in SphericalProjection. Perhaps it's even sufficient to only adapt the projection classes to get everything rendered correctly."
I don't think this is correct as there are render plugins which draw independent of the projection. For example the graticule and APRS plugins draw their own artifacts and hence the painter needs to be translated.
"One issue I currently see, however, is that the crosshairs don't indicate the center of the map. This results in the map shifting if pan != 0 and the map is zoomed in or out."
True. I believe the crosshairs now show the point on the globe closest to the viewer. This would have also been the case before when the globe was centered and it always happened to be the point at the center of the screen. Now as the globe is panned the closest point is no longer the center of the screen. I would like to avoid shifting the map when panning if possible. Any sggestions?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Last sentence should read " avoid shifting the map when zooming".
So just to clarify, is this an issue when zooming using just the keyboard? With the mouse my understanding is that the map follows the pointer. Is that incorrect?</pre>
<br />
<p>- Paul</p>
<br />
<p>On May 15th, 2013, 12:12 a.m. UTC, Paul Nader wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow and Dennis Nienhüser.</div>
<div>By Paul Nader.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 12:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Translates the scene viewpoint in a plane orthogonal to the line of sight of the viewer.
Version Changes
-------+-----------------------------------------------------------------
r6 Routing Layer now working :)
Reverted back to rendering while panning
Better overall FPS rate
Globe rotation adjusted while panning
Support for panning using keyboard and arrow disk widget arrows.
Bugfixes: https://github.com/oberluz/marble
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ubuntu 11.40 32-bit / Qt 4.8.1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.cpp <span style="color: grey">(50a4676)</span></li>
<li>src/lib/AbstractDataPlugin.cpp <span style="color: grey">(347f4b1)</span></li>
<li>src/lib/GoToDialog.cpp <span style="color: grey">(57b65de)</span></li>
<li>src/lib/LayerInterface.h <span style="color: grey">(46a20da)</span></li>
<li>src/lib/LayerInterface.cpp <span style="color: grey">(c3629de)</span></li>
<li>src/lib/LayerManager.cpp <span style="color: grey">(0df19d2)</span></li>
<li>src/lib/MapInfoDialog.cpp <span style="color: grey">(5219983)</span></li>
<li>src/lib/MarbleModel.h <span style="color: grey">(44a5f61)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(a84ccae)</span></li>
<li>src/lib/MarbleWidget.h <span style="color: grey">(9203250)</span></li>
<li>src/lib/MarbleWidget.cpp <span style="color: grey">(3b5e844)</span></li>
<li>src/lib/MarbleWidgetInputHandler.cpp <span style="color: grey">(1bdba92)</span></li>
<li>src/lib/PopupItem.cpp <span style="color: grey">(20391fc)</span></li>
<li>src/lib/Projections/SphericalProjection.cpp <span style="color: grey">(cebb73d)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(90355ed)</span></li>
<li>src/lib/RenderPlugin.cpp <span style="color: grey">(b9b95c9)</span></li>
<li>src/lib/ScanlineTextureMapperContext.cpp <span style="color: grey">(ff3197b)</span></li>
<li>src/lib/SphericalScanlineTextureMapper.h <span style="color: grey">(85ee814)</span></li>
<li>src/lib/SphericalScanlineTextureMapper.cpp <span style="color: grey">(0bfe09c)</span></li>
<li>src/lib/TextureColorizer.cpp <span style="color: grey">(5319c21)</span></li>
<li>src/lib/VectorMap.cpp <span style="color: grey">(cf3dcef)</span></li>
<li>src/lib/ViewportParams.h <span style="color: grey">(6b97f55)</span></li>
<li>src/lib/ViewportParams.cpp <span style="color: grey">(f82a8b7)</span></li>
<li>src/lib/layers/VectorMapLayer.cpp <span style="color: grey">(f05c88a)</span></li>
<li>src/lib/routing/RoutingInputWidget.cpp <span style="color: grey">(28db48d)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(125990d)</span></li>
<li>src/plugins/render/aprs/AprsPlugin.cpp <span style="color: grey">(550192f)</span></li>
<li>src/plugins/render/atmosphere/AtmospherePlugin.cpp <span style="color: grey">(492c111)</span></li>
<li>src/plugins/render/earthquake/EarthquakePlugin.cpp <span style="color: grey">(1205521)</span></li>
<li>src/plugins/render/navigation/ArrowDiscWidget.h <span style="color: grey">(77e5cdd)</span></li>
<li>src/plugins/render/navigation/ArrowDiscWidget.cpp <span style="color: grey">(ee81025)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp <span style="color: grey">(576198f)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopPlugin.cpp <span style="color: grey">(b1cef50)</span></li>
<li>src/plugins/render/photo/PhotoPlugin.cpp <span style="color: grey">(cdb6243)</span></li>
<li>src/plugins/render/postalcode/PostalCodePlugin.cpp <span style="color: grey">(87feacd)</span></li>
<li>src/plugins/render/stars/StarsPlugin.cpp <span style="color: grey">(d8d1a08)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(4be0c5d)</span></li>
<li>src/plugins/render/wikipedia/WikipediaPlugin.cpp <span style="color: grey">(89cf51e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110058/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/16/17._Satellites.png">Panned</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/Design_Notes.txt">Design Notes</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>