<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109379/">http://git.reviewboard.kde.org/r/109379/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2013, 5:17 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, looks really nice! Two nitpicks, though: I get every track listed twice in the menu, I wonder why this happens. Morevoer, the elevation profile doesn't display the relevant interval of V-shaped tracks when the bottom edge of the V isn't visible. When these issues are fixed, I'd give you a "Ship it". :)</pre>
</blockquote>
<p>On April 16th, 2013, 4:53 p.m. UTC, <b>Roman Karlstetter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you please send me a file for which this happens? Because I can't reproduce this with the files I have.
The same holds for the second point (even if I'm not completely sure that I understood it correctly).</pre>
</blockquote>
<p>On April 16th, 2013, 5 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll check this later. Could you please add "marble" to the group of reviewers, please? It seems as if our conversation is private, i.e. isn't distributed to Marble's developer mailing list. Thx!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How to reproduce that a .gpx file is shown more than once:
1) Start Marble (KDE version, latest master)
2) Enable the elevation profile float item
3) Open examples/gpx/mjolby.gpx from the Marble source code
Observe that mjolby.gpx is present more than once in the float item's context menu (6 times in my case)
Continue with reproducing an empty float item although the track is clearly visible:
4) Enable "Zoom to viewport" in the context menu
5) Center on Vikingstad on tile level 14
6) Keeping that zoom level, follow the track along the highway in western direction until road "206" is crossed
7) Follow the track along this road to Skänninge
Observe that the float item eventually says: "Not enough points in the viewport" although the track is clearly visible.</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On April 16th, 2013, 5:19 p.m. UTC, Roman Karlstetter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Bernhard Beschow.</div>
<div>By Roman Karlstetter.</div>
<p style="color: grey;"><i>Updated April 16, 2013, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes to the elevation profile plugin, it's now possible to display the height profile for a GPX-track opened from file.
I made a new classes for
a) providing the data, one for routes and one for tracks. They are in the same file, should this be split into multiple files?
b) the contextmenu, because it has some members which would only clutter ElevationProfileFloatItem. It is a friend class, is this ok?
Comments please :) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/CMakeLists.txt <span style="color: grey">(872e5e1)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.h <span style="color: grey">(cb3bff1)</span></li>
<li>src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp <span style="color: grey">(7cb3428)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109379/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>