<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110005/">http://git.reviewboard.kde.org/r/110005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2013, 4:59 p.m. UTC, <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good work, this patch looks very promising! How did you take the level of detail (present in the .pnt files) into account?</pre>
</blockquote>
<p>On April 15th, 2013, 5:25 p.m. UTC, <b>Thibaut Gridel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It isn't taken into account in GeoPainter atm.
The goal is to keep same display, support legend behaviour of checkboxen, and use geodata instead of legacy GeoPolygons (and btw fix #244025 and #307788).
Do you experience performance issue that mandates it before going with this patch? If so, this patch should wait for that implementation
in GeoDataLineString.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see. Have you run marble with --timedemo? Then we might have some numbers to talk about ;)</pre>
<br />
<p>- Bernhard</p>
<br />
<p>On April 13th, 2013, 9:26 p.m. UTC, Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated April 13, 2013, 9:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uses the GeoData model and rendering instead of the legacy Vector code.
Removed Classes are:
- GeoPolygon
- ScreenPolygon
- VectorComposer
- VectorMap
- VectorMapBaseLayer and
- VectorMapLayer</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Existing dgml files have been ported to still use <vector> tag if doable, otherwise to directly use <geodata>
All themes work, legend properties are functionnal still</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/maps/earth/bluemarble/bluemarble.dgml <span style="color: grey">(4e40406)</span></li>
<li>data/maps/earth/citylights/citylights.dgml <span style="color: grey">(8b72b60)</span></li>
<li>data/maps/earth/plain/plain.dgml <span style="color: grey">(0e329c0)</span></li>
<li>data/maps/earth/precip-dec/precip-dec.dgml <span style="color: grey">(77f38cf)</span></li>
<li>data/maps/earth/precip-july/precip-july.dgml <span style="color: grey">(f9e93f5)</span></li>
<li>data/maps/earth/schagen1689/schagen1689.dgml <span style="color: grey">(c68415c)</span></li>
<li>data/maps/earth/srtm/srtm.dgml <span style="color: grey">(d5b9810)</span></li>
<li>data/maps/earth/temp-dec/temp-dec.dgml <span style="color: grey">(4d62d72)</span></li>
<li>data/maps/earth/temp-july/temp-july.dgml <span style="color: grey">(394cb0e)</span></li>
<li>data/maps/sky/nightsky/nightsky.dgml <span style="color: grey">(f0d3777)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(534a7a9)</span></li>
<li>src/lib/GeoPolygon.h <span style="color: grey">(37fb401)</span></li>
<li>src/lib/GeoPolygon.cpp <span style="color: grey">(ba9da66)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(14ccd36)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(5df138a)</span></li>
<li>src/lib/ScreenPolygon.h <span style="color: grey">(a1001d5)</span></li>
<li>src/lib/TextureColorizer.h <span style="color: grey">(1fc2638)</span></li>
<li>src/lib/TextureColorizer.cpp <span style="color: grey">(f372830)</span></li>
<li>src/lib/VectorComposer.h <span style="color: grey">(b20db7c)</span></li>
<li>src/lib/VectorComposer.cpp <span style="color: grey">(4d9600c)</span></li>
<li>src/lib/VectorMap.h <span style="color: grey">(41a2e16)</span></li>
<li>src/lib/VectorMap.cpp <span style="color: grey">(cf3dcef)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlBrushTagHandler.cpp <span style="color: grey">(50ce419)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlPenTagHandler.cpp <span style="color: grey">(687ab61)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlSourceFileTagHandler.cpp <span style="color: grey">(f7c007f)</span></li>
<li>src/lib/geodata/handlers/dgml/DgmlVectorTagHandler.cpp <span style="color: grey">(b05ad8f)</span></li>
<li>src/lib/layers/CMakeLists.txt <span style="color: grey">(4efe657)</span></li>
<li>src/lib/layers/TextureLayer.h <span style="color: grey">(7c5f16c)</span></li>
<li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(1fe50d8)</span></li>
<li>src/lib/layers/VectorMapBaseLayer.h <span style="color: grey">(4934cb9)</span></li>
<li>src/lib/layers/VectorMapBaseLayer.cpp <span style="color: grey">(1bf1fbd)</span></li>
<li>src/lib/layers/VectorMapLayer.h <span style="color: grey">(14e168d)</span></li>
<li>src/lib/layers/VectorMapLayer.cpp <span style="color: grey">(f05c88a)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(d4cfec5)</span></li>
<li>tests/GeoPolygonTest.cpp <span style="color: grey">(1f68f84)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>