<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109061/">http://git.reviewboard.kde.org/r/109061/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initial impression looks pretty good (although I had doubts beforehand - sorry for that ;-)).</pre>
<br />
<p>- Torsten</p>
<br />
<p>On February 20th, 2013, 8:27 p.m. UTC, Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2013, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mostly code refactor and some fixes.
The goal is to separate concerns between projection specific issues and geodetic concerns.
Then corner cases for crossing the Idl, circling around a pole, moving past the horizon are easier to handle.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ProjectionTest does sanitization checks that screen polygons must satisfy:
closed, contain more than 2 points, no same point twice, repeats</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/Projections/AbstractProjection.cpp <span style="color: grey">(6c90e36)</span></li>
<li>src/lib/Projections/AbstractProjection_p.h <span style="color: grey">(1042c7e)</span></li>
<li>src/lib/Projections/CylindricalProjection.cpp <span style="color: grey">(a37060e)</span></li>
<li>src/lib/Projections/CylindricalProjection_p.h <span style="color: grey">(c34c6d0)</span></li>
<li>src/lib/Projections/SphericalProjection.cpp <span style="color: grey">(229103f)</span></li>
<li>src/lib/geodata/data/GeoDataLatLonBox.cpp <span style="color: grey">(d810dab)</span></li>
<li>src/lib/geodata/data/GeoDataLineString.h <span style="color: grey">(ce75340)</span></li>
<li>src/lib/geodata/data/GeoDataLineString.cpp <span style="color: grey">(231a85b)</span></li>
<li>src/lib/geodata/data/GeoDataLineString_p.h <span style="color: grey">(8559e31)</span></li>
<li>src/lib/geodata/data/GeoDataLinearRing.h <span style="color: grey">(9cfce6d)</span></li>
<li>src/lib/geodata/data/GeoDataLinearRing.cpp <span style="color: grey">(573e264)</span></li>
<li>tests/ProjectionTest.cpp <span style="color: grey">(8d4d71b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109061/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>