<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108687/">http://git.reviewboard.kde.org/r/108687/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e4c8a536f4bf80e93a92fd8249bfec82700825ff by Dennis Nienhüser to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 31st, 2013, 7:21 p.m. UTC, Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Thibaut Gridel.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 7:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds GeoDataDocument::baseUrl used by the kml/kmz plugin and resolvePath(). This way both .kmz and .kml files correctly load relative resources.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://kml-samples.googlecode.com/svn-history/r212/trunk/kml/Region/GroundOverlay/usa-ca-sf.kmz
- Download and open usa-ca-sf.kmz in Marble
- Unzip usa-ca-sf.kmz and load its doc.kml in Marble
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/data/GeoDataDocument.h <span style="color: grey">(46c9339)</span></li>
<li>src/lib/geodata/data/GeoDataDocument.cpp <span style="color: grey">(3537094)</span></li>
<li>src/lib/geodata/data/GeoDataDocument_p.h <span style="color: grey">(41f4b15)</span></li>
<li>src/lib/geodata/data/GeoDataObject.cpp <span style="color: grey">(abc10f4)</span></li>
<li>src/plugins/runner/kml/KmlRunner.cpp <span style="color: grey">(ef07219)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>