<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108618/">http://git.reviewboard.kde.org/r/108618/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108618/diff/1/?file=109387#file109387line179" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/annotate/AnnotatePlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">179</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">widgetInitalised</span> <span class="o">=</span> <span class="nb">true</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initialized
Note the additional "i" and the "z" instead of "s" which is consistent with usage in the Qt API.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108618/diff/1/?file=109387#file109387line265" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/annotate/AnnotatePlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">265</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QPointF</span> <span class="nf">bottomRight</span><span class="p">(</span><span class="n">m_marbleWidget</span><span class="o">-></span><span class="n">size</span><span class="p">().</span><span class="n">width</span><span class="p">(),</span> <span class="n">m_marbleWidget</span><span class="o">-></span><span class="n">size</span><span class="p">().</span><span class="n">height</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This code down to line 299 seems to be a faulty reinvention of the simple call
const GeoDataLatLonAltBox& ViewportParams::viewLatLonAltBox() const
Although in theory the approach via GeoDataLineString should work it will be inaccurate when looking at the poles. This is due to conceptual limitations in which bounding boxes for linestrings can be determined.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108618/diff/1/?file=109387#file109387line284" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/annotate/AnnotatePlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">284</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">" the Globe. Please only select a region"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Globe -> globe</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108618/diff/1/?file=109387#file109387line299" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/annotate/AnnotatePlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">299</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">GeoDataLatLonAltBox</span> <span class="n">bounds</span> <span class="o">=</span> <span class="n">GeoDataLatLonAltBox</span><span class="o">::</span><span class="n">fromLineString</span><span class="p">(</span> <span class="n">tempString</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See above - replace the code up to here, please</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108618/diff/1/?file=109391#file109391line33" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/render/annotate/GeoWidgetBubble.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">initaliseMarbleWidget</span><span class="p">(</span> <span class="n">QWidget</span><span class="o">*</span> <span class="n">parent</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">initializeMarbleWidget
^ ^</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On January 27th, 2013, 4:45 p.m. UTC, Thibaut Gridel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2013, 4:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The revival of osmannotate plugin which never got to release state.
The plugin layer handles SceneGraphicsItems for mouse event actions, and updates a document which is rendered with classical layers.
Still lots of work needed for production delivery, but already quite functionnal:
- Adds/Removes Point Placemarks, Polygons
- Import/Export to kml file
- Move Polygon points to reshape
- Placemark "edit bubble" which sets name and description
Needs work:
edit bubble is weak with painting and refreshing
"download osm" not touched, should be dropped from this plugin imho
The full work is available in a git branch (which will be rebased to commit to master):
git://anongit.kde.org/clones/marble/tgridel/marble.git:annotate</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/bitmaps/annotation.png <span style="color: grey">(330dea6)</span></li>
<li>data/bitmaps/hand.png <span style="color: grey">(0a7276c)</span></li>
<li>src/QtMainWindow.cpp <span style="color: grey">(9224240)</span></li>
<li>src/icons/document-export.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/document-import.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/draw-placemark.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/draw-polygon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/edit-delete-shred.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/hand.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/icons/remove.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/RenderPlugin.h <span style="color: grey">(577da7a)</span></li>
<li>src/lib/RenderPlugin.cpp <span style="color: grey">(18360cc)</span></li>
<li>src/marble.qrc <span style="color: grey">(7fcc47f)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(4d726b7)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/AreaAnnotation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/AreaAnnotation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/GeoWidgetBubble.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/GeoWidgetBubble.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/PlacemarkTextAnnotation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/PlacemarkTextAnnotation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/SceneGraphicsItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/SceneGraphicsItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/TextEditor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/TextEditor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/osmannotate/AreaAnnotation.h <span style="color: grey">(6bfbc3e)</span></li>
<li>src/plugins/render/osmannotate/AreaAnnotation.cpp <span style="color: grey">(ecabb14)</span></li>
<li>src/plugins/render/osmannotate/CMakeLists.txt <span style="color: grey">(e4297b1)</span></li>
<li>src/plugins/render/osmannotate/GeoWidgetBubble.h <span style="color: grey">(c7fe77c)</span></li>
<li>src/plugins/render/osmannotate/GeoWidgetBubble.cpp <span style="color: grey">(45f0fd8)</span></li>
<li>src/plugins/render/osmannotate/OsmAnnotatePlugin.h <span style="color: grey">(52f7579)</span></li>
<li>src/plugins/render/osmannotate/OsmAnnotatePlugin.cpp <span style="color: grey">(269db35)</span></li>
<li>src/plugins/render/osmannotate/PlacemarkTextAnnotation.h <span style="color: grey">(04fe56e)</span></li>
<li>src/plugins/render/osmannotate/PlacemarkTextAnnotation.cpp <span style="color: grey">(9ad300d)</span></li>
<li>src/plugins/render/osmannotate/TextAnnotation.h <span style="color: grey">(a3235c2)</span></li>
<li>src/plugins/render/osmannotate/TextAnnotation.cpp <span style="color: grey">(e58c175)</span></li>
<li>src/plugins/render/osmannotate/TextEditor.h <span style="color: grey">(59e68a5)</span></li>
<li>src/plugins/render/osmannotate/TextEditor.cpp <span style="color: grey">(689f724)</span></li>
<li>src/plugins/render/osmannotate/TmpGraphicsItem.h <span style="color: grey">(3526191)</span></li>
<li>src/plugins/render/osmannotate/TmpGraphicsItem.cpp <span style="color: grey">(4fcf1b4)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmBoundsGraphicsItem.h <span style="color: grey">(25420be)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmBoundsGraphicsItem.cpp <span style="color: grey">(f3db2d8)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmBoundsTagHandler.h <span style="color: grey">(ee1e085)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmBoundsTagHandler.cpp <span style="color: grey">(0341a0e)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmElementDictionary.h <span style="color: grey">(02f558e)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmElementDictionary.cpp <span style="color: grey">(3941751)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmNdTagHandler.h <span style="color: grey">(c797d9f)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmNdTagHandler.cpp <span style="color: grey">(21c95b2)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmNodeGraphicsItem.h <span style="color: grey">(5147471)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmNodeGraphicsItem.cpp <span style="color: grey">(ac319e3)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmNodeTagHandler.h <span style="color: grey">(dc8a978)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmNodeTagHandler.cpp <span style="color: grey">(52e3959)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmWayGraphicsItem.h <span style="color: grey">(1e15bbd)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmWayGraphicsItem.cpp <span style="color: grey">(db01729)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmWayTagHandler.h <span style="color: grey">(85fa75f)</span></li>
<li>src/plugins/render/osmannotate/osm/OsmWayTagHandler.cpp <span style="color: grey">(357948b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108618/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate1.jpg">Toolbar</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate2.jpg">Placemark bubble</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate3.jpg">Area</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate4.jpg">Moved Area</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/annotate5.jpg">TreeModel</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>