<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108632/">http://git.reviewboard.kde.org/r/108632/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108632/diff/1/?file=109457#file109457line122" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/runner/kml/KmlPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">removeDirectoryRecursively</span><span class="p">(</span> <span class="n">path</span> <span class="o">+</span> <span class="s">"/"</span> <span class="o">+</span> <span class="n">subdir</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't that be '/' in our Krazy world?</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On January 27th, 2013, 7:16 p.m. UTC, Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2013, 7:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extends the kml plugin to support opening .kmz files.
- ParseRunner gets access to MarbleModel
- KML plugin has an optional dependency on quazip
- When opening a .kmz file, quazip is used to extract the .kmz to a temporary location
- Last .kml file found in the .kmz is opened
- If the .kml is closed in Marble, the temporary files are removed
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opening some random .kmz files found on the Internet works.
TODO (for separate patches):
- Resolve files (images) in .kmz files correctly
- Fix Marble to delete plugins / close files correctly on shutdown
- Register .kmz files for opening with Marble
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=310059">310059</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/Findquazip.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/FileLoader.cpp <span style="color: grey">(93d7db0)</span></li>
<li>src/lib/MarbleRunnerManager.cpp <span style="color: grey">(1b312b1)</span></li>
<li>src/lib/ParsingRunner.h <span style="color: grey">(033fe60)</span></li>
<li>src/lib/ParsingRunner.cpp <span style="color: grey">(81458ce)</span></li>
<li>src/lib/RunnerTask.h <span style="color: grey">(956fd93)</span></li>
<li>src/lib/RunnerTask.cpp <span style="color: grey">(56f0628)</span></li>
<li>src/plugins/runner/kml/CMakeLists.txt <span style="color: grey">(35e00dc)</span></li>
<li>src/plugins/runner/kml/KmlPlugin.h <span style="color: grey">(527c2f1)</span></li>
<li>src/plugins/runner/kml/KmlPlugin.cpp <span style="color: grey">(fc23402)</span></li>
<li>src/plugins/runner/kml/KmlRunner.h <span style="color: grey">(d97f89a)</span></li>
<li>src/plugins/runner/kml/KmlRunner.cpp <span style="color: grey">(3278c78)</span></li>
<li>src/plugins/runner/kml/KmzHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/KmzHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>