<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108511/">http://git.reviewboard.kde.org/r/108511/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks a lot better already - I'd still like to know Dennis' opinion on this :)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108511/diff/4/?file=108461#file108461line24" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/TemplateDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * This class represents template engine for</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The class represents a template engine.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108511/diff/4/?file=108461#file108461line27" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/TemplateDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * to make includes like %!{include_name}%</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds interesting, but honestly: I have still no idea what includes do in this particular case. Could you explain it to me (as part of the docs)? :-)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108511/diff/4/?file=108461#file108461line40" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/TemplateDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @brief Returns current template value of @p key</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Returns "the" current ... :-)
Otherwise this particular part of the documentation is very good!</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108511/diff/4/?file=108461#file108461line47" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/TemplateDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @brief Set current @p value for the @p key</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Golden rule of thumb for API docs: If the API is named e.g.
void setFoo( key )
then try to avoid using the words "set", "Foo" and "key" in the explanation as much as reasonably possible. It's like the game where people are not allowed to say "black", "white", "yes" or "no".
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108511/diff/4/?file=108461#file108461line67" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/TemplateDocument.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @brief Final proceed text</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess you mean "processed" :-)</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On January 21st, 2013, 9:40 p.m. UTC, Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2013, 9:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A list of changes:
- Fixed Cities bug
- Added TemplateDocument class for templating things
- MarbleLegendBrowser tweaked (support of cool image borders, nice fonts, everything Bootstrap has)
- Added support of Bootstrap (http://twitter.github.com/bootstrap/index.html) in HTML of Marble
- MapInfoDialog improved (see MarbleLegendBrowser changes)
More about TemplateDocument:
- It use %var_name% to template the text
- String format %!{name}% will include library `name` into the HTML. Used in <head> tag</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on Qt version of Marble - everything is ok. Tests are passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/legend.html <span style="color: grey">(317b6cf)</span></li>
<li>data/maps/earth/openstreetmap/legend.html <span style="color: grey">(aa02426)</span></li>
<li>data/maps/earth/schagen1689/legend.html <span style="color: grey">(db3f171)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(59ad8d2)</span></li>
<li>src/lib/MarbleLegendBrowser.cpp <span style="color: grey">(fad7020)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(eb608be)</span></li>
<li>src/lib/TemplateDocument.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/TemplateDocument.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/htmlfeatures/bootstrap.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/htmlfeatures/bootstrap.min.css <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/libmarble.qrc <span style="color: grey">(7753834)</span></li>
<li>src/lib/webpopup/city.html <span style="color: grey">(764f3c3)</span></li>
<li>src/lib/webpopup/geoplace.html <span style="color: grey">(4abca92)</span></li>
<li>src/lib/webpopup/nation.html <span style="color: grey">(4bfe9a0)</span></li>
<li>src/lib/webpopup/placesscreen.css <span style="color: grey">(b25f73d)</span></li>
<li>src/lib/webpopup/skyplace.html <span style="color: grey">(707f30f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108511/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-old.png">Old Historic Legend</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-old.png">Old OSM Legend</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-historic-new.png">New Histroric Legend</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-old.png">Old Temperature Legend</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-osm-new.png">New OSM Legend</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-temp-new.png">New Temperature Legend</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/compare-ukraine-new.png">New MapInfoDialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>