<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108143/">http://git.reviewboard.kde.org/r/108143/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108143/diff/1/?file=104399#file104399line245" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/MarbleWidgetPopupMenu.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MarbleWidgetPopupMenu::slotInfoDialog()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">243</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">isGeoPlace</span> <span class="o">=</span> <span class="p">(</span><span class="n">index</span><span class="o">-></span><span class="n">visualCategory</span><span class="p">()</span> <span class="o">==</span> <span class="n">GeoDataFeature</span><span class="o">::</span><span class="n">GeographicPole</span> <span class="o">||</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">244</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cm"><span class="hl">/*</span>bool isGeoPlace = (index->visualCategory() == GeoDataFeature::GeographicPole ||</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please remove before committing</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On January 3rd, 2013, 9:12 p.m., Illya Kovalevskyy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.</div>
<div>By Illya Kovalevskyy.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2013, 9:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Get rid of PlacemarkInfoDialog and migrate the remaining placemarks according to GCI task:
- http://www.google-melange.com/gci/task/view/google/gci2012/8156205</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything is OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/CMakeLists.txt <span style="color: grey">(cd82954)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.h <span style="color: grey">(c3594c9)</span></li>
<li>src/lib/MarbleWidgetPopupMenu.cpp <span style="color: grey">(13b37f9)</span></li>
<li>src/lib/PlacemarkInfoDialog.h <span style="color: grey">(d303984)</span></li>
<li>src/lib/PlacemarkInfoDialog.cpp <span style="color: grey">(8c78b91)</span></li>
<li>src/lib/PlacemarkInfoDialog.ui <span style="color: grey">(056fefd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108143/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108143/s/967/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/03/fin-lord-1_400x100.png" style="border: 1px black solid;" alt="Current View 1" /></a>
<a href="http://git.reviewboard.kde.org/r/108143/s/968/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/03/fin-lord-2_400x100.png" style="border: 1px black solid;" alt="Current View 2" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>