<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108039/">http://git.reviewboard.kde.org/r/108039/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fb08fee2b68c75e16c1cc2d6f361683abb1be751 by Dennis Nienhüser to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 30th, 2012, 10:19 p.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Thibaut Gridel.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 10:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Resolves relative (local) paths relative to the kml url base path as said in https://developers.google.com/kml/documentation/kmzarchives?hl=de#externalrefs
Fixes loading of icons in icon styles when they are defined as relative local path names, e.g. <IconStyle><Icon><href>myicon.png</href></Icon></IconStyle> and myicon.png next to the .kml file containing such definition.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rabet.kml and Overlay.kml from examples/kml/. Note that Rabet.kml needs to be modified to have the ylw-pushpin.png downloaded next to the .kml and the URL transformed to a local file (<href>ylw-pushpin.png</href>)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/geodata/data/GeoDataDocument.cpp <span style="color: grey">(2bd7f2a)</span></li>
<li>src/lib/geodata/data/GeoDataFeature.h <span style="color: grey">(6979370)</span></li>
<li>src/lib/geodata/data/GeoDataFeature.cpp <span style="color: grey">(0bf2337)</span></li>
<li>src/lib/geodata/data/GeoDataIconStyle.cpp <span style="color: grey">(b221821)</span></li>
<li>src/lib/geodata/data/GeoDataObject.h <span style="color: grey">(33267a9)</span></li>
<li>src/lib/geodata/data/GeoDataObject.cpp <span style="color: grey">(30e09af)</span></li>
<li>src/lib/geodata/data/GeoDataOverlay.cpp <span style="color: grey">(eef24f6)</span></li>
<li>src/lib/geodata/data/GeoDataStyle.cpp <span style="color: grey">(01c4a24)</span></li>
<li>tests/TestGeoData.cpp <span style="color: grey">(815e726)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108039/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>