<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108021/">http://git.reviewboard.kde.org/r/108021/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fd773f2fa55d2a947baf2ea6cb4173893e9381d4 by Illya Kovalevskyy to branch master.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On December 30th, 2012, 10:24 a.m., Illya Kovalevskyy wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.</div>
<div>By Illya Kovalevskyy.</div>


<p style="color: grey;"><i>Updated Dec. 30, 2012, 10:24 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Weather Plugin has been migrated to usage of MapInfoDialog successfully according to GCI task:
 - https://google-melange.appspot.com/gci/task/view/google/gci2012/8097206</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built & Tested with love.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plugins/render/weather/AbstractWeatherService.h <span style="color: grey">(8c8ce0e)</span></li>

 <li>src/plugins/render/weather/AbstractWeatherService.cpp <span style="color: grey">(251fe4d)</span></li>

 <li>src/plugins/render/weather/BBCWeatherService.cpp <span style="color: grey">(02898c1)</span></li>

 <li>src/plugins/render/weather/CMakeLists.txt <span style="color: grey">(7b48dc9)</span></li>

 <li>src/plugins/render/weather/GeoNamesWeatherService.cpp <span style="color: grey">(202a9c3)</span></li>

 <li>src/plugins/render/weather/WeatherItem.h <span style="color: grey">(09829f9)</span></li>

 <li>src/plugins/render/weather/WeatherItem.cpp <span style="color: grey">(ae80079)</span></li>

 <li>src/plugins/render/weather/WeatherModel.h <span style="color: grey">(7613b5f)</span></li>

 <li>src/plugins/render/weather/WeatherModel.cpp <span style="color: grey">(e6580d3)</span></li>

 <li>src/plugins/render/weather/WeatherPlugin.h <span style="color: grey">(844f5b6)</span></li>

 <li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(dd5e3de)</span></li>

 <li>src/plugins/render/weather/data/marble_deco.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-clear-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-clear.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-clouds-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-clouds.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-few-clouds-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-few-clouds.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-freezing-rain.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-hail.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-many-clouds.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-mist.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-showers-day.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-showers-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-showers-scattered-day.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-showers-scattered-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-showers-scattered.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-showers.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-snow-rain.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-snow-scattered-day.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-snow-scattered-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-snow-scattered.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-snow.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-storm-day.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-storm-night.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather-storm.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weather.html <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/data/weatherscreen.css <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/plugins/render/weather/weather.qrc <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108021/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/108021/s/938/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/30/alp-lord-1_400x100.png" style="border: 1px black solid;" alt="Usecase 1" /></a>

 <a href="http://git.reviewboard.kde.org/r/108021/s/939/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/30/alp-lord-2_400x100.png" style="border: 1px black solid;" alt="Usecase 2" /></a>

 <a href="http://git.reviewboard.kde.org/r/108021/s/940/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/30/alp-lord-3_400x100.png" style="border: 1px black solid;" alt="Usecase 3" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>