<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107919/">http://git.reviewboard.kde.org/r/107919/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes much sense. Please commit.</pre>
<br />
<p>- Dennis</p>
<br />
<p>On December 26th, 2012, 11:07 a.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2012, 11:07 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The network plugin infrastructure represents a network abstraction layer.
However, Marble uses QNetworkAccessManager in a number of places directly, e.g. in the GHNS dialogs and in all the runners.
Given that QNetworkAccessManager also represents a network abstraction layer, Marble's own network plugin infrastructure shouldn't be neccessary.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/AbstractDataPlugin.h <span style="color: grey">(37ab9213d8e9a53ccc189b436868fb41a55c7f7a)</span></li>
<li>src/lib/AbstractDataPlugin.cpp <span style="color: grey">(8398e3193dbf8741683547c18007551ca410dabb)</span></li>
<li>src/lib/AbstractDataPluginModel.h <span style="color: grey">(04be73f5edc3197b226f59c6dfacc5c4a6e6374b)</span></li>
<li>src/lib/AbstractDataPluginModel.cpp <span style="color: grey">(92d2cb89e00f5620eff9a2279ccb099266da173c)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(3d39e739b7c1bfaa46a4e46cd8589e76f707a328)</span></li>
<li>src/lib/HttpDownloadManager.h <span style="color: grey">(0da4b9ef83c9ca2eccf223e76363b0102565ab22)</span></li>
<li>src/lib/HttpDownloadManager.cpp <span style="color: grey">(62c40308b3696758dddf1692de4098c845d23ccf)</span></li>
<li>src/lib/HttpJob.h <span style="color: grey">(5b7565333a9801a5309a2b82d29d52e26cb983df)</span></li>
<li>src/lib/HttpJob.cpp <span style="color: grey">(454c7e6a3ee1732e1cf2c91d3b63b7b52dcd43e9)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(5f885e9f3339602df6b59c8a556e16cad487f9e9)</span></li>
<li>src/lib/NetworkPlugin.h <span style="color: grey">(4a4d1f0d2949374bcf45e0d761c7fc1958ef2709)</span></li>
<li>src/lib/NetworkPlugin.cpp <span style="color: grey">(67f257c00647519844e6bf5231c4d8cdf8991ff3)</span></li>
<li>src/lib/NetworkPluginInterface.h <span style="color: grey">(0d198bcf62672a218d6587f1f8a36ffc1ec71151)</span></li>
<li>src/lib/NetworkPluginInterface.cpp <span style="color: grey">(6de86a1301bc07f15ef924bfecbccc0da93a2b67)</span></li>
<li>src/lib/PluginManager.h <span style="color: grey">(c9a156de6805509c207914a514121ea2e53e0c90)</span></li>
<li>src/lib/PluginManager.cpp <span style="color: grey">(9c36744b44d1153a35cbd0912b0001cb4b8f9b59)</span></li>
<li>src/plugins/CMakeLists.txt <span style="color: grey">(25c8bdf0df0796df6d7ac39762cc30629b25f71b)</span></li>
<li>src/plugins/declarative/DeclarativeDataPlugin.cpp <span style="color: grey">(0455f9ccf67d2600423b99f1761f792f353ed8ff)</span></li>
<li>src/plugins/declarative/DeclarativeDataPluginModel.h <span style="color: grey">(469975f5547b836d401492089c4bd277a424a575)</span></li>
<li>src/plugins/declarative/DeclarativeDataPluginModel.cpp <span style="color: grey">(48460db9147fce04f966f345e48813620a9816e9)</span></li>
<li>src/plugins/network/CMakeLists.txt <span style="color: grey">(260738f2323c266cc3314e79238a24f1f6d0c628)</span></li>
<li>src/plugins/network/kio/CMakeLists.txt <span style="color: grey">(b933ba1cf64b763db9ad037f9213acec6660ac72)</span></li>
<li>src/plugins/network/kio/KIONetworkPlugin.h <span style="color: grey">(33b03c10603ce4b62f288b9568dacac72b78dfe2)</span></li>
<li>src/plugins/network/kio/KIONetworkPlugin.cpp <span style="color: grey">(3adcacacb798a1dedd49fec88016def189fdbf6d)</span></li>
<li>src/plugins/network/qhttp/CMakeLists.txt <span style="color: grey">(7695c93d249c4b305068ace8164063b415227b98)</span></li>
<li>src/plugins/network/qhttp/QHttpNetworkPlugin.h <span style="color: grey">(9cd5186a61a01e1ab5bd8955fafdb041338a6ede)</span></li>
<li>src/plugins/network/qhttp/QHttpNetworkPlugin.cpp <span style="color: grey">(fa2dca8ce0fca52751b6af736d2e1a331cd195bc)</span></li>
<li>src/plugins/network/qnam/CMakeLists.txt <span style="color: grey">(dffc34413b672874e329b4e1e53250010a1ec35a)</span></li>
<li>src/plugins/network/qnam/QNamDownloadJob.h <span style="color: grey">(674938e851a017d29615305612ffc7082be08cb3)</span></li>
<li>src/plugins/network/qnam/QNamDownloadJob.cpp <span style="color: grey">(fb90dac7f3d66b0818ab7aaf174ff0d8dfc0662c)</span></li>
<li>src/plugins/network/qnam/QNamNetworkPlugin.h <span style="color: grey">(2aa11fff0d3efc0580cdd790084449b3c8179861)</span></li>
<li>src/plugins/network/qnam/QNamNetworkPlugin.cpp <span style="color: grey">(bf5fbf5917a1e26867cfc9f831cdd56a71f143f4)</span></li>
<li>src/plugins/render/earthquake/EarthquakeModel.h <span style="color: grey">(bd74e3a751c64a5bbcde6341d96cbb1835edafc1)</span></li>
<li>src/plugins/render/earthquake/EarthquakeModel.cpp <span style="color: grey">(d08c982d0079cf589176b3cffef74400a08779db)</span></li>
<li>src/plugins/render/earthquake/EarthquakePlugin.cpp <span style="color: grey">(014c04f4fd994737ebd208009e932221b3d53395)</span></li>
<li>src/plugins/render/foursquare/FoursquareModel.h <span style="color: grey">(940de81d0bf6d03c1a3dba390284d7074c1db7f5)</span></li>
<li>src/plugins/render/foursquare/FoursquareModel.cpp <span style="color: grey">(9f8374981c8eed6f4e31e0980887f5c4acad490f)</span></li>
<li>src/plugins/render/foursquare/FoursquarePlugin.cpp <span style="color: grey">(fc8112fa3f9e82ced8f7aa77c34c704c07c4470e)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.h <span style="color: grey">(b508006386fe1c99a439c9d1284359174d656ef5)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.cpp <span style="color: grey">(9bc2e70ba881a85bd0eb62e31a0eff792dec1fd0)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp <span style="color: grey">(7a017d1d7df21bb27b767b897186936f5722a7db)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopModel.h <span style="color: grey">(7fe8970873e6ac5357fac242211febd679061b96)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopModel.cpp <span style="color: grey">(fcd5271e983cdb7c24d44e976cffa50904694d9d)</span></li>
<li>src/plugins/render/opendesktop/OpenDesktopPlugin.cpp <span style="color: grey">(883a5a002a523bc354ba5889386ea551bd5eaed1)</span></li>
<li>src/plugins/render/photo/PhotoPlugin.cpp <span style="color: grey">(935fe6e55d350ce434f3ac7c508778f2c98663a0)</span></li>
<li>src/plugins/render/photo/PhotoPluginModel.h <span style="color: grey">(a007424982920e60608d05842945c721c74d1b3c)</span></li>
<li>src/plugins/render/photo/PhotoPluginModel.cpp <span style="color: grey">(a9d683c6368ab301527956fc8eae7c4c85bfbb2d)</span></li>
<li>src/plugins/render/postalcode/PostalCodeModel.h <span style="color: grey">(d285f1fc085ea804053a2b9e06a3cfa949f8f364)</span></li>
<li>src/plugins/render/postalcode/PostalCodeModel.cpp <span style="color: grey">(479ce565ac2e6bd3b2d9cc1ada6a098470fb3b47)</span></li>
<li>src/plugins/render/postalcode/PostalCodePlugin.cpp <span style="color: grey">(2018bc7715178ab065557eaed7b91cde63b6c7ee)</span></li>
<li>src/plugins/render/satellites/SatellitesModel.h <span style="color: grey">(f559c9efb16814f34c1c2d818492474fa71faa39)</span></li>
<li>src/plugins/render/satellites/SatellitesModel.cpp <span style="color: grey">(a6a6f597f77af0e3f3de65ed3bbff3e40ae6e7f1)</span></li>
<li>src/plugins/render/satellites/SatellitesPlugin.cpp <span style="color: grey">(7344f1bc4677bc0141f24da2ee7240567a642b2c)</span></li>
<li>src/plugins/render/satellites/TrackerPluginModel.h <span style="color: grey">(925b24303e554eb2cba902f39075275aa4a1a6c6)</span></li>
<li>src/plugins/render/satellites/TrackerPluginModel.cpp <span style="color: grey">(5b99631d05e601f2e1db3e013a74a27073f60229)</span></li>
<li>src/plugins/render/weather/WeatherModel.h <span style="color: grey">(7613b5ff640374c1f7052cd7ac3ac2d6f9f2c537)</span></li>
<li>src/plugins/render/weather/WeatherModel.cpp <span style="color: grey">(e6580d373ec28e7615021579c6e01b8b2c8c8a4b)</span></li>
<li>src/plugins/render/weather/WeatherPlugin.cpp <span style="color: grey">(dd5e3de3ac749bfa51d12b1450c4a75d8901edac)</span></li>
<li>src/plugins/render/wikipedia/WikipediaModel.h <span style="color: grey">(5b78a4e78342641c6ab9613fc9d7043a87208b80)</span></li>
<li>src/plugins/render/wikipedia/WikipediaModel.cpp <span style="color: grey">(58aeb1051dbf386a471f82206a23e2f6b438df97)</span></li>
<li>src/plugins/render/wikipedia/WikipediaPlugin.cpp <span style="color: grey">(43eb1752683643e73fa5f85146f68715e957f962)</span></li>
<li>tests/PluginManagerTest.cpp <span style="color: grey">(58bdfa3fd7c5e26a843ab378aab2610c238d843f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>