<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107980/">http://git.reviewboard.kde.org/r/107980/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5f70481eebe9f53f073265b5c5f6aad8c08f0a7e by Kevin Krammer to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 28th, 2012, 3:45 p.m., Mohammed Nafees wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Kevin Krammer.</div>
<div>By Mohammed Nafees.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2012, 3:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://www.google-melange.com/gci/task/view/google/gci2012/8084211
Fixed all QLatin1String issues and one code error in FileStorageWatcher.cpp</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, tested and compiled </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.cpp <span style="color: grey">(6fa7ab6)</span></li>
<li>src/lib/CurrentLocationWidget.cpp <span style="color: grey">(e828275)</span></li>
<li>src/lib/FileStoragePolicy.cpp <span style="color: grey">(ce92d10)</span></li>
<li>src/lib/FileStorageWatcher.cpp <span style="color: grey">(4bc56b2)</span></li>
<li>src/lib/MarbleLegendBrowser.cpp <span style="color: grey">(1b85898)</span></li>
<li>src/lib/NewstuffModel.cpp <span style="color: grey">(0606096)</span></li>
<li>src/lib/routing/RoutingLayer.cpp <span style="color: grey">(e5e803c)</span></li>
<li>src/lib/routing/instructions/WaypointParser.cpp <span style="color: grey">(1a49f68)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(b313fd4)</span></li>
<li>src/plugins/declarative/MapThemeModel.cpp <span style="color: grey">(6449696)</span></li>
<li>src/plugins/declarative/Routing.cpp <span style="color: grey">(5f2c15a)</span></li>
<li>src/plugins/declarative/Tracking.cpp <span style="color: grey">(f908833)</span></li>
<li>src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp <span style="color: grey">(3a21ee4)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.cpp <span style="color: grey">(8a3032b)</span></li>
<li>src/plugins/render/satellites/SatellitesModel.cpp <span style="color: grey">(a6a6f59)</span></li>
<li>src/plugins/render/weather/BBCWeatherService.cpp <span style="color: grey">(67dfff1)</span></li>
<li>src/plugins/render/weather/GeoNamesWeatherService.cpp <span style="color: grey">(697b8ed)</span></li>
<li>src/plugins/runner/local-osm-search/LocalOsmSearchPlugin.cpp <span style="color: grey">(d29b298)</span></li>
<li>src/plugins/runner/monav/MonavConfigWidget.cpp <span style="color: grey">(cacbc63)</span></li>
<li>src/plugins/runner/open-source-routing-machine/OSRMRunner.cpp <span style="color: grey">(b48c0f9)</span></li>
<li>src/qtmain.cpp <span style="color: grey">(ebfbac9)</span></li>
<li>tools/iau2kml/iau2kml.cpp <span style="color: grey">(e61674d)</span></li>
<li>tools/osm-addresses/main.cpp <span style="color: grey">(aa6749d)</span></li>
<li>tools/osm-sisyphus/upload.cpp <span style="color: grey">(3dc7f9e)</span></li>
<li>tools/poly2kml/main.cpp <span style="color: grey">(bc7e237)</span></li>
<li>tools/translations/merge_ts_po.cpp <span style="color: grey">(ce51967)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107980/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>