<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107510/">http://git.reviewboard.kde.org/r/107510/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's the license of the icons btw?</pre>
<br />
<p>- Torsten</p>
<br />
<p>On November 30th, 2012, 11:25 p.m., Anders Lund wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Anders Lund.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2012, 11:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a render plugins showing geocaches from opencaching.com on the map.
Capabilities:
* shows geocaches on the map, using icons derived from opencaching.com graphics
* shows a tooltip with the most important data when icons are hovered
* provides a dialog with details, description, hint and recent logs for each geocache
* the dialog shows the distance to the cache if available, otherwise the distance to the users home location as known by marble (calculated at the time the dialog is shown)
Good translation support, ui and known translatable datas from the remote service are marked for translation.
The plugin is trying to use graphics and colors from the remote service in an unobtrusive way, so that the data is easily recognizable but does not interfer with the application or desktop style.
Possible future improvements:
* show geocache tags in graphical form (easy)
* show opencaching "verifyable" attributes for each cache (easy)
* allow registering/logging a visit to a cache (requires oauth based login)
* show users found caches by marking the icons with an emblem or special color (requires oauth based login)
* update distance data in dialog when it changes (easy)
* show a "go to" widget with live updated distance/bearing/course
You can find icons here: http://owncloud.alweb.dk/public.php?service=files&file=%2Fanders%2Ffiles%2Foccicons.tar.bz2 - unpack in marble root directory</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, compiles and functions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/render/opencachingcom/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/CacheDetailsDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComItem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/multi-cache-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/multi-cache.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/opencachingcom.qrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/puzzle-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/puzzle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/traditional-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/traditional.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/unknown-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/unknown.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/virtual-m.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/opencachingcom/virtual.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107510/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107510/s/858/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/29/marble-opencaching_400x100.png" style="border: 1px black solid;" alt="opencaching.com data and tooltip" /></a>
<a href="http://git.reviewboard.kde.org/r/107510/s/859/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/29/marble-opencaching-details_400x100.png" style="border: 1px black solid;" alt="Cache details dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>