<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105315/">http://git.reviewboard.kde.org/r/105315/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2012, 10:05 a.m., <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch, I would like to see it committed. I'm wondering, though, why you needed to move so many lines? Is there a possibility to split the patch in two, where the first one moves the lines (if at all necessary) and where the second one applies the change in behavior?</pre>
</blockquote>
<p>On July 10th, 2012, 10:22 a.m., <b>Bernhard Beschow</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Forgot to mention: I'm asking because this separation of concerns would make judgment of the change more clear to us. Most (all?) of us develop under Linux, so having separate commits where one affects all OSes and where the other one affects only OS X would help us to keep track of future changes more easily.</pre>
</blockquote>
<p>On October 6th, 2012, 12:52 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How shall we move forward here?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, that I didn't care about the patch during the last months, I was busy with some other stuff. But it is sitting near the top of my agenda. When I find some time, I will follow your proposal and split it into smaller patches - the platform independent ones and the mac specific one(s). This should end with something like 1-x platform independent patches for storing lists of filenames in variables instead of directly using them and some small mac specific ones.
Sadly, I don't have access to any linux machine at the moment, so testing will be somewhat limited. </pre>
<br />
<p>- Kathrin</p>
<br />
<p>On June 21st, 2012, 10:25 a.m., Kathrin Geilmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Kathrin Geilmann.</div>
<p style="color: grey;"><i>Updated June 21, 2012, 10:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch builds the marble library as an OSX Framework. It bundles libmarblewidget, headers, data files and plugins into marblewidget.framework, which gets installed at FRAMEWORK_INSTALL_DIR (/Library/Frameworks by default).
The marble application bundle uses the framework. In order to make the framework find the data files and plugins, the pathmagick in MarbleDirs removed, it uses the osx functions for finding the resource paths of a bundle instead of hard coded paths.
Additionally a cmake warning about the bundle destination and Bug 299029 are fixed.
The patch influences QTOnly builds on OSX.
Unfortunately I cannot test that the change to MarbleDirs does not break KDE builds on OSX. As far as I see it should result in exactly the same behavior as before, because I just replaced the path magick with standard osx functions.
Sidenotes: - For deploying marble.app the framework should be included in the app bundle -> the procedure to build the dmg should be adapted accordingly.
- Using make install is mandatory, otherwise the datafiles and plugins are not copied into the framework. It would be nice to use the RESOURCE property for frameworks, but I couldn't figure out how to preserve the directory structure of the data directory. Using it, would allow to create the framework complete in the make step.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a) Tested on my development system: OSX 10.6.8, cmake 2.8.7, Qt 4.7.4, 64bit machine, QTONLY build
b) Ubuntu 04.12, cmake 2.8.7, Qt 4.8.1, KDE 4.8.3, (All installed from ubuntu packages), QTOnly and KDE builds. -> As expected no changes were found.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(388826cb86f5fd7c02e1237e3c315148f1feaccf)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b33ec4fdcad7e3c5d8c0c0262c9746361f12f26d)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(27ac7eca50982cd1f61e7691ceed9095aa114da9)</span></li>
<li>src/lib/MarbleDirs.h <span style="color: grey">(0a52b96bdaaedbd84f4d35f441acb2ec7810ae2a)</span></li>
<li>src/lib/MarbleDirs.cpp <span style="color: grey">(3984fda4f1169ee74ed41c3b3848bec113a35a41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105315/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>