<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107474/">http://git.reviewboard.kde.org/r/107474/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch looks great, please commit.</pre>
<br />
<p>- Dennis</p>
<br />
<p>On November 26th, 2012, 1:01 p.m., Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2012, 1:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, tests are disable if not compiling in QTONLY mode, making testing more difficult when compiling as KDE application.
The patch makes it possible to compile (and possibly also run) tests when compiling with kdelibs:
- set BUILD_MARBLE_TESTS according to KDE4_BUILD_TESTS
- introduce a new marble_add_qtonly_test, similar to marble_add_test, to compile a test only in QTONLY mode
- setup the kde4 include directories
- define -DQT_GUI_LIB to make QtTest aware that they are gui tests
- compile TestGeoSceneWriter and MercatorProjectionTest only in QTONLY mode, as they use internal classes (not exported, so unavailable when symbol visibility is used)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">marble and tests compile fine with and without -DQTONLY=ON.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d9205a6529c16db54f88a12ecda2225244c92ed8)</span></li>
<li>MarbleMacros.cmake <span style="color: grey">(5e1a1e56995eb5b9b3a64db803ab47e4838e00f1)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(55d78f26862b19066cdb7317fdd5d227cf13d248)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107474/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>