<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107015/">http://git.reviewboard.kde.org/r/107015/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you please push this? While policy does not require it to be committed before hard freeze today, I still think it's better to commit it soon since it might affect packaging.
</pre>
<br />
<p>- Dennis</p>
<br />
<p>On October 23rd, 2012, 9:15 p.m., Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2012, 9:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do like Okular does, separate desktop files per all installed plugins. So with distris which package each plugin in a separate package Marble will never claim to support a file type until it really does.
See also http://lists.kde.org/?l=kde-devel&m=135083816331959&w=2 and comment from Thibaut on http://git.reviewboard.kde.org/r/106977/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/marble.desktop <span style="color: grey">(0808f93)</span></li>
<li>src/marble_part.desktop <span style="color: grey">(e6146d4)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(bee89ac)</span></li>
<li>src/plugins/runner/gpx/marble_gpx.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/marble_part_gpx.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/CMakeLists.txt <span style="color: grey">(f92b313)</span></li>
<li>src/plugins/runner/kml/marble_kml.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/kml/marble_part_kml.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/CMakeLists.txt <span style="color: grey">(3ee2475)</span></li>
<li>src/plugins/runner/osm/marble_osm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/marble_part_osm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/CMakeLists.txt <span style="color: grey">(d3d9ccd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107015/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>