<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103672/">http://git.reviewboard.kde.org/r/103672/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 0a467d8c5684badfdf2141317a3c9e0172cbb6cd by Anders Lund to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 5th, 2012, 9 a.m., Anders Lund wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and Thibaut Gridel.</div>
<div>By Anders Lund.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2012, 9 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">GPX improvements, without sym (icon) handling
This patch
* makes route handling simpler, just displays a blue (oxygen color) linestring
* handles type, cmt, desc, link (GPX 1.19 and url (GPX 1.0)
- links are added to the description, and http url handling is turned on in the infodialog description view
- cmt is used as display name where present. The rationale is that this is what it is meant for: it is a field for a user friendly name of a waypoint for small gps devices with very small screens.
- desc is shown in the information dialog
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have used this quite a bit, and of cause verified that it compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/PlacemarkInfoDialog.cpp <span style="color: grey">(e9889ee5bd609c8e1aaed66aed0a22e437ae8b14)</span></li>
<li>src/plugins/runner/gpx/CMakeLists.txt <span style="color: grey">(bee89acc8bf899022c692474b297a5f15c615411)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXElementDictionary.h <span style="color: grey">(cce7476d5ac411271e8961a61334a7496e38da13)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp <span style="color: grey">(2f9f2d096cf4aa191a341d89e1cf65c1dd4f60cb)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp <span style="color: grey">(d3f9d1001b3d18a51b853b77a783e4502ea6f31b)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXlinkTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXlinkTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp <span style="color: grey">(400c9c89d1b1c4b0b52d9120c2161d20c6f4b46a)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp <span style="color: grey">(022744d58719e6a95f02865a91e0906c6a25d8cf)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h <span style="color: grey">(c5b420a713922d1f425013364d66072b75f498fc)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp <span style="color: grey">(994fcbf473b131afb815b9b308ac48138de7f2b7)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXurlTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXurlTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXurlnameTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXurlnameTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp <span style="color: grey">(b7efbe4d01c486e7a460202d181412a74f730684)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103672/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>