<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106977/">http://git.reviewboard.kde.org/r/106977/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2012, 10:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add application/x-gpx+xml, application/x-osm+xml, application/x-esri-shape to the mime-type database</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch installs an extension of the mimetype database for the three file types.
This way such files get a nicer display in the file dialogs/managers and can also finally be bound to the Marble program by the mimetype ids.
To have Marble noted as handler for application/x-esri-shape only if the related plugin is installed, I followed the advise of Albert, see http://lists.kde.org/?l=kde-devel&m=135083816331959&w=2
Still to do after this patch:
* have the view zoom to the loaded shape/track
Patch additionally installs a mimetype for the Esri shapefile index, so this file at least looks better in the filemanager.
That mimetype is made up by me. Not sure if this is useful, could also remove this from the patch if you prefer. For that reason I have also not yet added entries for the two other additional file types with shapefiles.
PS: After applying the patch and installing somehow the new info about the mimetypes and that marble supports them seems to not make it to all running programs. For me it worked only completely after a restart of the workspace session, so please try that before reporting problems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clicking an gpx file or a shape file starts Marble and loads the file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7f8777e)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(316d005)</span></li>
<li>data/mimetypes/XmlMessages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/mimetypes/geo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/marble.desktop <span style="color: grey">(3b61616)</span></li>
<li>src/marble_part.desktop <span style="color: grey">(9a75d07)</span></li>
<li>src/plugins/runner/shp/CMakeLists.txt <span style="color: grey">(0ef8c65)</span></li>
<li>src/plugins/runner/shp/marble_part_shp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/shp/marble_shp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106977/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>