<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106007/">http://git.reviewboard.kde.org/r/106007/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d1bcf0204e02f95cf866a1650b1321f4dcf7bcea by Ander Pijoan to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 14th, 2012, 12:18 p.m., Ander Pijoan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Ander Pijoan.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2012, 12:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extension for the .osm file parser. Relations can be built with different ways (for example for describing a building with a hole in it) tagged as members.
So with this diff, <member> tag is parsed and ways are stored for then a relation to have them available if necessary.
Moreover a relation can also contain another relation, so a relation factory has also been created to store them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done with some .osm files with different ways of representing buildings and using relations. Works OK.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/osm/CMakeLists.txt <span style="color: grey">(6e92624)</span></li>
<li>src/plugins/runner/osm/OsmParser.cpp <span style="color: grey">(5285566)</span></li>
<li>src/plugins/runner/osm/handlers/OsmElementDictionary.h <span style="color: grey">(2d40f6b)</span></li>
<li>src/plugins/runner/osm/handlers/OsmElementDictionary.cpp <span style="color: grey">(c99d4a9)</span></li>
<li>src/plugins/runner/osm/handlers/OsmGlobals.cpp <span style="color: grey">(0b5ea25)</span></li>
<li>src/plugins/runner/osm/handlers/OsmMemberTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeFactory.h <span style="color: grey">(b9c6580)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeFactory.cpp <span style="color: grey">(c51e373)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp <span style="color: grey">(f433a5d)</span></li>
<li>src/plugins/runner/osm/handlers/OsmOsmTagHandler.cpp <span style="color: grey">(997f628)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp <span style="color: grey">(057eb63)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp <span style="color: grey">(fdcd2a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106007/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106007/s/675/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/14/OsmParserImprovement_400x100.png" style="border: 1px black solid;" alt="Osm parser test" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>