<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105655/">http://git.reviewboard.kde.org/r/105655/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 28ee42947cdbe0b3d856d27495de380b54a9c51d by Thibaut Gridel to branch sok-2012-plasma-active.</pre>
 <br />







<p>- Commit</p>


<br />
<p>On July 23rd, 2012, 7:51 p.m., Thibaut Gridel wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Marble.</div>
<div>By Thibaut Gridel.</div>


<p style="color: grey;"><i>Updated July 23, 2012, 7:51 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Each Layer can output a debug() QString.
The layerManager will display timing information and that debug.
The option is controlled by marble --debugLayers in qt and kde, and also by the widget()->setShowLayerDebug( true );

Some trace examples made for TextureLayer, GeometryLayer and PlacemarkLayer</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Interesting Benchmarks to come!</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdemain.cpp <span style="color: grey">(110fa11)</span></li>

 <li>src/lib/LayerInterface.h <span style="color: grey">(0d0f1a7)</span></li>

 <li>src/lib/LayerInterface.cpp <span style="color: grey">(5a22130)</span></li>

 <li>src/lib/LayerManager.h <span style="color: grey">(71dd130)</span></li>

 <li>src/lib/LayerManager.cpp <span style="color: grey">(bdf266b)</span></li>

 <li>src/lib/MarbleMap.h <span style="color: grey">(ce36abb)</span></li>

 <li>src/lib/MarbleMap.cpp <span style="color: grey">(7ee671e)</span></li>

 <li>src/lib/MarbleWidget.h <span style="color: grey">(1e5f12e)</span></li>

 <li>src/lib/MarbleWidget.cpp <span style="color: grey">(dab1178)</span></li>

 <li>src/lib/PlacemarkLayout.h <span style="color: grey">(7657910)</span></li>

 <li>src/lib/PlacemarkLayout.cpp <span style="color: grey">(f9032b4)</span></li>

 <li>src/lib/RenderPlugin.h <span style="color: grey">(47eac22)</span></li>

 <li>src/lib/RenderPlugin.cpp <span style="color: grey">(feb1e64)</span></li>

 <li>src/lib/layers/GeometryLayer.h <span style="color: grey">(c27b5ea)</span></li>

 <li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(9eda316)</span></li>

 <li>src/lib/layers/PlacemarkLayer.h <span style="color: grey">(e2c4131)</span></li>

 <li>src/lib/layers/PlacemarkLayer.cpp <span style="color: grey">(f687aea)</span></li>

 <li>src/lib/layers/TextureLayer.h <span style="color: grey">(8b03d0e)</span></li>

 <li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(5712945)</span></li>

 <li>src/qtmain.cpp <span style="color: grey">(d1bb781)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105655/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/105655/s/642/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/22/debug_400x100.png" style="border: 1px black solid;" alt="" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>