<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105598/">http://git.reviewboard.kde.org/r/105598/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 16th, 2012, 8:27 p.m., <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch does not work when the QTONLY=TRUE option is enabled (i.e. Marble is built without KDE), because the macro_optional_find_package is a KDE cmake macro. We'd need to copy it to our cmake macros or provide a similar macro for the patch to work in all cases.
$ grep QTONLY CMakeCache.txt
QTONLY:BOOL=TRUE
$ cmake ../src
CMake Error at src/plugins/positionprovider/CMakeLists.txt:3 (macro_optional_find_package):
Unknown CMake command "macro_optional_find_package".
-- Configuring incomplete, errors occurred!
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point. Any objection to copying the macro then?
If adding another macro is not desired, another option could be to do the work of the macro manually.</pre>
<br />
<p>- Michael</p>
<br />
<p>On July 16th, 2012, 7:49 p.m., Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated July 16, 2012, 7:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dependencies required to build Marble plugins are currently automagic - there is no way for the end user to disable them if the dependency is present.
This patch simply fixes that, adding new configure options -DWITH_{libgps,liblocation,QtLocation}.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/positionprovider/CMakeLists.txt <span style="color: grey">(43e3b1373728553b634cf1c0ce7c078adcb8aad0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105598/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>