<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105152/">http://git.reviewboard.kde.org/r/105152/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, one less class, code refactor and more consistent naming.</pre>
<br />
<p>- Thibaut</p>
<br />
<p>On June 5th, 2012, 11:48 a.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated June 5, 2012, 11:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PlacemarkLayout used to be both responsible for laying out placemarks and painting them. After having determined the layout, it realized painting by delegating the acutal work to PlacemarkPainter.
By reversing composition, PlacemarkPainter would ask PlacemarkLayout to update the layout before it would paint the placemarks itself. That way, PlacemarkPainter becomes a layer and PlacemarkLayout would be the layer's model, which is a common pattern in Marble.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with Atlas theme; Cities seem to be rendered like before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/CMakeLists.txt <span style="color: grey">(1208f5fed336d78723090269bb631285361dcb56)</span></li>
<li>src/lib/MarbleMap.cpp <span style="color: grey">(73a56fce591f51a89a83b5db65ed6b9b56bc0a13)</span></li>
<li>src/lib/PlacemarkLayout.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/PlacemarkLayout.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/PlacemarkPainter.h <span style="color: grey">(9e3d2aa913d4452dcec4f0dc6e01a9252d90e058)</span></li>
<li>src/lib/PlacemarkPainter.cpp <span style="color: grey">(2ca9fa7b0044cd672db711919f3a6c88f3c1eb83)</span></li>
<li>src/lib/layers/CMakeLists.txt <span style="color: grey">(460d9fbe29627253383485566cfae02e362e1459)</span></li>
<li>src/lib/layers/PlacemarkLayer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/layers/PlacemarkLayer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/layers/PlacemarkLayout.h <span style="color: grey">(cfad7f7ea27854bfcbe00100d4905604e5add954)</span></li>
<li>src/lib/layers/PlacemarkLayout.cpp <span style="color: grey">(e28ad242d2368f09476b41fafb3008119f0a70c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105152/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>