<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103656/">http://git.reviewboard.kde.org/r/103656/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 87cce17ba8156d7aee03a799b7fda8e78702f290 by Dennis Nienhüser to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 8th, 2012, 10:30 a.m., Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2012, 10:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Our current FindMarble.cmake script installed to the cmake module path puts the marble suffix into the include search path. This means that an
#include <marble/MarbleWidget.h>
does not work in general (only if the path below happens to be in the search path by some other reasons, e.g. because it is the standard path /usr/include). This is quite bad as something like #include <global.h> is likely to clash with other libraries' includes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The examples in examples/cpp (which have <marble/class.h> includes) now work for local installations when configuring cmake with
cmake -DCMAKE_MODULE_PATH=~/marble/export/share/marble/cmake \
-DCMAKE_INCLUDE_PATH=~/marble/export/include \
-DCMAKE_LIBRARY_PATH=~/marble/export/lib \
.
Previously MARBLE_INCLUDE_DIR hat to be adjusted manually.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=282865">282865</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>FindMarble.cmake <span style="color: grey">(7f81911)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103656/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>