<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104922/">http://git.reviewboard.kde.org/r/104922/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble and Ralf Habacker.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated May 12, 2012, 12:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provides timestamp now and handles feet unit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd like to have Linux distributions ship Marble with the flightgear position provider plugin. Currently that's unlikely to happen as the major distributions do not package the nmea library used by the plugin. I looked into replacing the dependency with gpsd/libgps, but unfortunately the sparse set of methods libgps provides only allows to parse json data or handle the communication via a socket.
The nmea format is quite simple however and flightgear only uses a small subset of it -- two of the sentences used are relevant to us. Therefore it's not too complicated to write our own parser without an additional dependency.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FlightGear version 2.4.0 on Linux, started with
fgfs --nmea=socket,out,5,localhost,5500,udp
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Findnmealib.cmake <span style="color: grey">(7f14058)</span></li>
<li>src/plugins/positionprovider/CMakeLists.txt <span style="color: grey">(d3cfc3d)</span></li>
<li>src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.h <span style="color: grey">(c7c7dac)</span></li>
<li>src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp <span style="color: grey">(af0eb9a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104922/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>