<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104905/">http://git.reviewboard.kde.org/r/104905/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d9aa520917a5b7ed370dab8de4618be854a9cbde by Bernhard Beschow to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 10th, 2012, 6:07 p.m., Bernhard Beschow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Bernhard Beschow.</div>
<p style="color: grey;"><i>Updated May 10, 2012, 6:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Having the list of supported file types generated avoids having to update the hardcoded lists in the source code. In addition, it allows 3rd-party developers to add parsing plugins w/o having to touch Marble code.
Unfortunately, there is one caveat: When loading one of Marbles .cache files, the contained placemarks are sometimes not shown. This is probably the reason why the .cache format is currently not listed as a supported format.
According to idis, the placemarks are not shown for the following reason: A typical map theme causes all available .cache files to be loaded such thath the placemarks are available in the search database. Some map themes, e.g. OSM, disable the visibility of the containded placemarks when they are not strictly needed. As a result, even loading a .cache file manually does not seem to "work" in these cases.
In order to work around this, and in order to preserve the current behavior, I've "internalized" the .cache file plugin into libmarblewidget. It could be turned into a "real" plugin again once we solve the above issue. Meanwhile, the .cache file format could be considered "internal" to Marble.
What do you think?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to work under Qt-only/Linux, KDE/Linux, Qt-only/Windows. In the latter case (under wine), the file extensions are shown.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/QtMainWindow.cpp <span style="color: grey">(7552eb56856d114bb86eb6605c435d58e35cfeab)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(21ddad432df3e399807cf4457812abfc48d37f91)</span></li>
<li>src/lib/CachePlugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CachePlugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CacheRunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/CacheRunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/MarbleRunnerManager.cpp <span style="color: grey">(c74e108f674b975ed651a83db5eaa25e655a6869)</span></li>
<li>src/marble_part.cpp <span style="color: grey">(d6613a7a834a05bf1130c622e0c13b55be996611)</span></li>
<li>src/plugins/runner/CMakeLists.txt <span style="color: grey">(4ab295aedd6ff6fa217818fb9d6c3b5135595c35)</span></li>
<li>src/plugins/runner/cache/CMakeLists.txt <span style="color: grey">(ed1760a62197636bf37fa1af6eafe25913bf8a4a)</span></li>
<li>src/plugins/runner/cache/CachePlugin.h <span style="color: grey">(4dfe44b7534519b81c530c4b98c08a1bab706daa)</span></li>
<li>src/plugins/runner/cache/CachePlugin.cpp <span style="color: grey">(cb2c84cbe540e87909c1e39fe002cdd3ba674df0)</span></li>
<li>src/plugins/runner/cache/CacheRunner.h <span style="color: grey">(6cc6710a9c1e287e9b739899925306a9fc0fc68d)</span></li>
<li>src/plugins/runner/cache/CacheRunner.cpp <span style="color: grey">(a1d414782e180decc93501d438974e47759388ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104905/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>